Page MenuHomeFreeBSD
Differential D58228

LinuxKPI: Add tgid to task_struct under sched.h
ClosedPublic
Actions

Authored by siri_racha.ca on Jul 14 2026, 5:27 PM.
Tags
Referenced Files
F172823235: D58228.diff
Mon, Sep 21, 7:53 AM
Unknown Object (File)
Fri, Sep 18, 6:27 PM
Unknown Object (File)
Sun, Sep 13, 11:09 PM
Unknown Object (File)
Sat, Sep 12, 4:11 AM
Unknown Object (File)
Sat, Sep 12, 3:40 AM
Unknown Object (File)
Fri, Sep 11, 6:19 PM
Unknown Object (File)
Fri, Sep 11, 10:47 AM
Unknown Object (File)
Thu, Sep 10, 9:11 PM
View All 90 Files
Subscribers
bz
dumbbell
emaste
imp

Details

Reviewers
bz
Group Reviewers
linuxkpi
Commits
rG3716da91b1a6: LinuxKPI: Add tgid to task_struct under sched.h
Summary

The amdkfd driver requires the tgid to be apart of the task_struct.
This patch introduces the tgid member to task_struct.

Sponsored By: The FreeBSD Foundation

Test Plan

Ran a test build, and builds with no issues.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

siri_racha.ca created this revision.Jul 14 2026, 5:27 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptJul 14 2026, 5:27 PM
siri_racha.ca requested review of this revision.Jul 14 2026, 5:27 PM
siri_racha.ca updated this revision to Diff 183134.Jul 30 2026, 8:35 PM

tab aligned struct member

siri_racha.ca added a project: Linux Emulation.Aug 12 2026, 3:17 PM
bz added a subscriber: bz.Aug 12 2026, 3:20 PM

What's the KBI impact of this? Does it need a __FreeBSD_version bump then? Would it make sense to add it to the end?

siri_racha.ca added a comment.Aug 12 2026, 3:31 PM

Just bumping if anyone has time

siri_racha.ca added a comment.Aug 13 2026, 5:33 PM
In D58228#1349195, @bz wrote:

What's the KBI impact of this? Does it need a __FreeBSD_version bump then? Would it make sense to add it to the end?

It does break KBI... I did not consider that. I've made a revision to gaurd via __FreeBSD_version, though it bumps from 19->21 since someone bumped to 20 last night.

siri_racha.ca updated this revision to Diff 184004.Aug 13 2026, 5:33 PM
siri_racha.ca added a child revision: D58845: LinuxKPI: Add cpufreq_quick_get_max to LinuxKPI for amdkfd support.Tue, Aug 25, 7:02 PM
siri_racha.ca removed a child revision: D58845: LinuxKPI: Add cpufreq_quick_get_max to LinuxKPI for amdkfd support.Thu, Sep 3, 8:11 PM
siri_racha.ca updated this revision to Diff 185798.Fri, Sep 4, 4:48 AM
siri_racha.ca edited the summary of this revision. (Show Details)
siri_racha.ca edited the test plan for this revision. (Show Details)

Fixed formatting, incremented to correct value, fixed description, added test plan.

siri_racha.ca added a parent revision: D57465: LinuxKPI: Create `linux/util_macros.h`.Fri, Sep 4, 4:51 AM
siri_racha.ca edited the test plan for this revision. (Show Details)Fri, Sep 4, 5:22 AM

@bz If you have some time, can you let me know if there are any additional changes I should make?

bz requested changes to this revision.Fri, Sep 4, 5:23 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/sched.h
80

This is not right. The structure field should always be unconditional.

This revision now requires changes to proceed.Fri, Sep 4, 5:23 PM
siri_racha.ca added inline comments.Sun, Sep 6, 4:44 AM
sys/compat/linuxkpi/common/include/linux/sched.h
80

Hmmm ok, to make sure I understand why so I don't make this mistake again can you confirm this;
This change would break KABI becauses it changes the layout of the struct.
In this case, because the FreeBSD kernel header files are always compiled against the kernel source tree they belong to, it would always evaluate to True, making this useless.
But we should still bump the __FreeBSD_version so that external code knows that there was a KPI change.

On a related note, it got bumped to 1600023 on CURRENT, so I need to fix this again.

siri_racha.ca updated this revision to Diff 185990.Sun, Sep 6, 4:47 AM
bz accepted this revision.Sun, Sep 6, 4:21 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/sched.h
80

Right. Also in addition to all this it gets complicated when you start MFCing.
Bumping __FreeBSD_version will make the external kmod packages (the ones from the special repo) being rebuilt.
For as long as the header is not used in further code that's fine. We (I) still do not have a full understanding of that.

Given we do bump __FreeBSD_version I am not sure how much we win in this particular case by adding the field to the end.
You just do the final bump before the commit; there's no need for extra review for that.
You may also want to add an UPDATING entry saying that LinuxKPI modules must be recompiled (there should be examples from dumbbell or me there).

Lastly after the commit please document the __FreeBSD_version bump in the docs as indicated in the comment in param.h right above it.

This revision is now accepted and ready to land.Sun, Sep 6, 4:21 PM
bz added a subscriber: dumbbell.Mon, Sep 7, 9:09 PM

Hi,
sorry, I somehow assumed you have a commit bit. This is not the case, right? So @dumbbell , @emaste, or I need to commit your changes?

siri_racha.ca added a comment.Tue, Sep 8, 4:41 AM

Yeah, sorry about the confusion.

Closed by commit rG3716da91b1a6: LinuxKPI: Add tgid to task_struct under sched.h (authored by siri_racha.ca, committed by emaste). · Explain WhyWed, Sep 9, 7:01 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG3716da91b1a6: LinuxKPI: Add tgid to task_struct under sched.h.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
4 lines
sys/
2 lines

Diff 184004

View Options

sys/compat/linuxkpi/common/include/linux/sched.h

Loading...
View Options

sys/sys/param.h

Loading...