Paths

Table of Contentst

Differential D58075

LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility.
ClosedPublic
Actions

Authored by siri_racha.ca on Jul 7 2026, 7:19 AM.

Tags

Referenced Files

	F174792233: D58075.diff
	Tue, Oct 6, 12:46 AM

	F174684454: D58075.id186297.diff
	Mon, Oct 5, 4:28 AM

	Unknown Object (File)
	Mon, Oct 5, 1:21 AM

	Unknown Object (File)
	Sun, Oct 4, 3:38 PM

	Unknown Object (File)
	Sun, Oct 4, 1:15 PM

	Unknown Object (File)
	Sun, Oct 4, 4:08 AM

	Unknown Object (File)
	Sat, Oct 3, 8:59 PM

	Unknown Object (File)
	Sat, Oct 3, 7:18 PM

View All 81 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGb8b2be57af15: LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility

Summary

jiffies64_to_msecs is used by kfd_process.c in the amd/amdkfd driver from
Linux kernel 6.12.

Sponsored By: FreeBSD Foundation

Test Plan

Built kernel, and booted with no issues.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

siri_racha.ca created this revision.Jul 7 2026, 7:19 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptJul 7 2026, 7:19 AM

siri_racha.ca requested review of this revision.Jul 7 2026, 7:19 AM

siri_racha.ca edited the summary of this revision. (Show Details)

dumbbell accepted this revision.Jul 9 2026, 10:02 PM

This revision is now accepted and ready to land.Jul 9 2026, 10:02 PM

Patch does not apply:

$ git arc patch -c D58075
Applying D58075...
 INFO  Base commit is not in local repository; trying to fetch.
Checking patch sys/compat/linuxkpi/common/include/linux/jiffies.h...
error: while searching for:
extern unsigned long jiffies;  /* defined in sys/kern/subr_ticks.S */
#define        jiffies_64              jiffies /* XXX-MJ wrong on 32-bit platforms */
#define        jiffies_to_msecs(x)     ((unsigned int)(((int64_t)(int)(x)) * 1000 / hz))

#define        MAX_JIFFY_OFFSET        ((LONG_MAX >> 1) - 1)


error: patch failed: sys/compat/linuxkpi/common/include/linux/jiffies.h:39
Applying patch sys/compat/linuxkpi/common/include/linux/jiffies.h with 1 reject...
Rejected hunk #1.

 Patch Failed! 
Usage Exception: Unable to apply patch!

It looks like the patch is on top of a version of this file where tabs have been converted to spaces. Can you please re-generate with whitespace unchanged?

emaste mentioned this in D58076: LinuxKPI: Add compat_ptr_ioctl.Aug 17 2026, 4:47 PM

siri_racha.ca added a child revision: D58845: LinuxKPI: Add cpufreq_quick_get_max to LinuxKPI for amdkfd support.Aug 25 2026, 7:02 PM

Should be updated with the fixed tabs @emaste

This revision now requires review to proceed.Aug 26 2026, 4:15 AM

lgtm

Let's just hope x * 1000 will never overflow.

This change builds fine too when applied on top of 74c539fd1cefdbc993411274c613434c3f23b4b1

siri_racha.ca edited the summary of this revision. (Show Details)Sep 3 2026, 8:10 PM

siri_racha.ca edited the test plan for this revision. (Show Details)

siri_racha.ca added a child revision: D57465: LinuxKPI: Create `linux/util_macros.h`.

siri_racha.ca removed a child revision: D58845: LinuxKPI: Add cpufreq_quick_get_max to LinuxKPI for amdkfd support.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 9, 8:01 PM

Closed by commit rGb8b2be57af15: LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility (authored by dumbbell). · Explain Why

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rGb8b2be57af15: LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

1 line

Diff 186297

sys/compat/linuxkpi/common/include/linux/jiffies.h

Loading...