Paths

Table of Contentst

Differential D58076

LinuxKPI: Add compat_ptr_ioctl
AcceptedPublic
Actions

Authored by siri_racha.ca on Tue, Jul 7, 7:38 AM.

Tags

Referenced Files

	F162346049: D58076.diff
	Sun, Jul 12, 7:27 AM

	F162293427: D58076.id181437.diff
	Sat, Jul 11, 6:57 PM

	Unknown Object (File)
	Fri, Jul 10, 11:56 PM

	Unknown Object (File)
	Fri, Jul 10, 6:03 PM

Subscribers

Details

Reviewers

Group Reviewers

Summary

Added compat_ptr_ioctl, it's required by amdkfd https://github.com/torvalds/linux/blob/0e35b9b6ec0ffcc5e23cbdec09f5c622ad532b53/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c#L60

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

siri_racha.ca created this revision.Tue, Jul 7, 7:38 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptTue, Jul 7, 7:38 AM

siri_racha.ca requested review of this revision.Tue, Jul 7, 7:38 AM

dumbbell requested changes to this revision.Thu, Jul 9, 9:58 PM

dumbbell added a subscriber: dumbbell.

dumbbell added inline comments.

sys/compat/linuxkpi/common/include/linux/fs.h
438–441	I would swap the logic like this: if (unlocked_ioctl == NULL) return (-ENOIOCTLCMD); return (file->...);
439	`arg` is already an unsigned long, the cast is not needed.

This revision now requires changes to proceed.Thu, Jul 9, 9:58 PM

Updated function

siri_racha.ca marked 2 inline comments as done.Fri, Jul 10, 10:37 PM

siri_racha.ca added inline comments.

sys/compat/linuxkpi/common/include/linux/fs.h
438–441	Done/Amended

dumbbell accepted this revision.Sat, Jul 11, 8:22 AM

This revision is now accepted and ready to land.Sat, Jul 11, 8:22 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

9 lines

Diff 181760

sys/compat/linuxkpi/common/include/linux/fs.h

Loading...