Page MenuHomeFreeBSD

LinuxKPI: Add compat_ptr_ioctl
AcceptedPublic

Authored by siri_racha.ca on Tue, Jul 7, 7:38 AM.
Referenced Files
F164628695: D58076.diff
Sun, Aug 2, 4:30 PM
F164560161: D58076.id181437.diff
Sun, Aug 2, 2:33 AM
F164556854: D58076.id181760.diff
Sun, Aug 2, 2:08 AM
Unknown Object (File)
Sat, Aug 1, 7:06 AM
Unknown Object (File)
Thu, Jul 30, 5:45 PM
Unknown Object (File)
Mon, Jul 27, 4:13 AM
Unknown Object (File)
Sat, Jul 25, 1:33 AM
Unknown Object (File)
Wed, Jul 22, 10:03 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell requested changes to this revision.Thu, Jul 9, 9:58 PM
dumbbell added a subscriber: dumbbell.
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/fs.h
438โ€“441

I would swap the logic like this:

if (unlocked_ioctl == NULL)

return (-ENOIOCTLCMD);

return (file->...);

439

arg is already an unsigned long, the cast is not needed.

This revision now requires changes to proceed.Thu, Jul 9, 9:58 PM
siri_racha.ca added inline comments.
sys/compat/linuxkpi/common/include/linux/fs.h
438โ€“441

Done/Amended

This revision is now accepted and ready to land.Sat, Jul 11, 8:22 AM