Page MenuHomeFreeBSD

LinuxKPI: Add compat_ptr_ioctl
AcceptedPublic

Authored by siri_racha.ca on Jul 7 2026, 7:38 AM.
Referenced Files
Unknown Object (File)
Mon, Aug 17, 2:26 AM
Unknown Object (File)
Fri, Aug 14, 7:34 PM
Unknown Object (File)
Thu, Aug 13, 7:06 PM
Unknown Object (File)
Thu, Aug 13, 9:50 AM
Unknown Object (File)
Thu, Aug 13, 5:29 AM
Unknown Object (File)
Thu, Aug 13, 1:25 AM
Unknown Object (File)
Tue, Aug 11, 6:41 PM
Unknown Object (File)
Mon, Aug 10, 11:14 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell requested changes to this revision.Jul 9 2026, 9:58 PM
dumbbell added a subscriber: dumbbell.
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/fs.h
438โ€“441

I would swap the logic like this:

if (unlocked_ioctl == NULL)

return (-ENOIOCTLCMD);

return (file->...);

439

arg is already an unsigned long, the cast is not needed.

This revision now requires changes to proceed.Jul 9 2026, 9:58 PM
siri_racha.ca added inline comments.
sys/compat/linuxkpi/common/include/linux/fs.h
438โ€“441

Done/Amended

This revision is now accepted and ready to land.Jul 11 2026, 8:22 AM

Same trouble applying as D58075 (presumed whitespace)