Paths

Table of Contentst

Differential D58076

LinuxKPI: Add compat_ptr_ioctl
ClosedPublic
Actions

Authored by siri_racha.ca on Jul 7 2026, 7:38 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Sep 11, 1:38 PM

	Unknown Object (File)
	Fri, Sep 11, 9:49 AM

	Unknown Object (File)
	Fri, Sep 11, 7:53 AM

	Unknown Object (File)
	Thu, Sep 10, 7:19 PM

	Unknown Object (File)
	Thu, Sep 10, 4:54 AM

	Unknown Object (File)
	Wed, Sep 9, 10:15 AM

	Unknown Object (File)
	Tue, Sep 8, 11:18 AM

	Unknown Object (File)
	Tue, Sep 8, 4:39 AM

View All 78 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGeb9e38e37c82: linuxkpi: Add compat_ptr_ioctl

Summary

Adding the compat_ptr_ioctl function for amdkfd support it's called by
kfd_chardev.c

Test Plan

Passes test build.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

siri_racha.ca created this revision.Jul 7 2026, 7:38 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptJul 7 2026, 7:38 AM

siri_racha.ca requested review of this revision.Jul 7 2026, 7:38 AM

dumbbell requested changes to this revision.Jul 9 2026, 9:58 PM

dumbbell added a subscriber: dumbbell.

dumbbell added inline comments.

sys/compat/linuxkpi/common/include/linux/fs.h
438–441	I would swap the logic like this: if (unlocked_ioctl == NULL) return (-ENOIOCTLCMD); return (file->...);
439	`arg` is already an unsigned long, the cast is not needed.

This revision now requires changes to proceed.Jul 9 2026, 9:58 PM

Updated function

siri_racha.ca marked 2 inline comments as done.Jul 10 2026, 10:37 PM

siri_racha.ca added inline comments.

sys/compat/linuxkpi/common/include/linux/fs.h
438–441	Done/Amended

dumbbell accepted this revision.Jul 11 2026, 8:22 AM

This revision is now accepted and ready to land.Jul 11 2026, 8:22 AM

siri_racha.ca marked an inline comment as done.Jul 12 2026, 11:08 PM

Same trouble applying as D58075 (presumed whitespace)

siri_racha.ca added a child revision: D58845: LinuxKPI: Add cpufreq_quick_get_max to LinuxKPI for amdkfd support.Tue, Aug 25, 7:02 PM

siri_racha.ca edited the summary of this revision. (Show Details)Thu, Sep 3, 7:19 PM

siri_racha.ca removed a child revision: D58845: LinuxKPI: Add cpufreq_quick_get_max to LinuxKPI for amdkfd support.Thu, Sep 3, 8:11 PM

Fixed Whitespace issues

This revision now requires review to proceed.Sun, Sep 6, 5:04 AM

@emaste white space issues should be fixed now
cc @dumbbell

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 11, 9:51 AM

Closed by commit rGeb9e38e37c82: linuxkpi: Add compat_ptr_ioctl (authored by siri_racha.ca, committed by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGeb9e38e37c82: linuxkpi: Add compat_ptr_ioctl.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

9 lines

Diff 185991

sys/compat/linuxkpi/common/include/linux/fs.h

Loading...