LinuxKPI: Create `linux/util_macros.h`

[siri_racha.ca]

Summary

In new amdgpu patches, the for_each_if macro starts being used. It is defined in linux/util_macros.h. This macro begins being used in the amdgpu driver provided in Linux kernel version 6.12, and 6.14. The macro is gaurded to only be used if LINUXKPI_VERSION is above `

[dumbbell]

for_each_if() already exists in the DRM drivers. It was moved to <linux/util_macros.h> in Linux 6.15 (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b2108fc82a0acda34388bff3e3ee3544013b1623). Therefore it will need to be wrapped with:

#if defined(LINUXKPI_VERSION) && LINUXKPI_VERSION >= 61500
#define for_each_if...
#endif

This is to avoid the risk of double definitions when used with DRM drivers from versions before 6.15.

sys/compat/linuxkpi/common/include/linux/pm.h

35 ↗

(On Diff #179264)

Linux doesn’t do that, even on e.g. 7.0.

When the macro was moved to <linux/util_macros.h>, <drm/drm_util.h> started to include it directly. There should be no need for this include.

[siri_racha.ca]

sys/compat/linuxkpi/common/include/linux/pm.h

35 ↗

(On Diff #179264)

Oh, I see. I originally made the patch the header wasn't there yet. I'm looking at Linux 6.18.4, and it seems to still include it here. Should I remove the include?

[siri_racha.ca]

Now guarded so it is only used if LinuxKPI version is abov 61500

[siri_racha.ca]

Previous diff was incorrect

[dumbbell]

sys/compat/linuxkpi/common/include/linux/util_macros.h

35

I believe the second part has reversed logic: for_each_if() should be defined here if LINUXKPI_VERSION >= 61500. Before that, it is defined in <drm/drm_util.h>.

The first part is fine.

[siri_racha.ca]

sys/compat/linuxkpi/common/include/linux/util_macros.h

35

Should be fixed

[siri_racha.ca]

Just bumping

[bz]

sys/compat/linuxkpi/common/include/linux/util_macros.h

2

• no longer needed

3

I cannot remember what @imp said last time if this according to style goes below or if this was to be relaxed again?

10

Do we need the full copy of the license given we have the SPDX?

35

If this is used by drm-kmod 6.12 already why do we only enable it for >= 6.15? Ah I see @dumbbell 's comment. Please make sure the commit message gets adjusted before push!

[siri_racha.ca]

sys/compat/linuxkpi/common/include/linux/util_macros.h

3

Had a look at style(9) and it says to just do Copyright + "SPDX-License-Identifier: BSD-2-Clause", I'll remove the rest in a bit, I kinda just copied it from another file

35

Will update in next revision, thanks for the catch!!

[bz]

sys/compat/linuxkpi/common/include/linux/util_macros.h

2

While it is still true that the *-* is no longer needed, you can just remove it before committing or leaving it.