Page MenuHomeFreeBSD
Differential D58059

runtime: add the ability to set exterrors in userspace
Needs ReviewPublic
Actions

Authored by brooks on Mon, Jul 6, 4:06 PM.
Tags
None
Referenced Files
F164394663: D58059.id182528.diff
Fri, Jul 31, 12:28 PM
F164357539: D58059.diff
Fri, Jul 31, 3:51 AM
F164338761: D58059.id182455.diff
Thu, Jul 30, 11:12 PM
F164324661: D58059.id182464.diff
Thu, Jul 30, 7:39 PM
Unknown Object (File)
Thu, Jul 30, 1:53 PM
Unknown Object (File)
Wed, Jul 29, 8:25 AM
Unknown Object (File)
Wed, Jul 29, 8:21 AM
Unknown Object (File)
Wed, Jul 29, 8:19 AM
View All 35 Files
Subscribers
emaste
imp
ziaee

Details

Reviewers
kib
mckusick
Group Reviewers
cheri
Summary

The UEXTERROR(3) macro is a partial analog to EXTERROR(9) that sets
the current user exterror state and errno. The main difference is
that it returns no value and sets errno directly since that's the
typical pattern in libraries.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 75081
Build 71964: arc lint + arc unit

Event Timeline

brooks created this revision.Mon, Jul 6, 4:06 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 6, 4:06 PM
brooks requested review of this revision.Mon, Jul 6, 4:06 PM
Herald added a reviewer: cheri. · View Herald TranscriptMon, Jul 6, 4:06 PM
Harbormaster completed remote builds in B74552: Diff 181372.Mon, Jul 6, 4:06 PM
brooks added a parent revision: D58058: exterr: relax format restrictions.Mon, Jul 6, 4:06 PM
brooks added a child revision: D58060: exterr(9): add a few tests of new message formats.
brooks added a comment.Mon, Jul 6, 4:11 PM

The big thing that needs to be dealt with for this to make sense is to have a way to specify the filename that isn't a table embedded in libc. A first cut could be a special index that means no-file and perhaps using -1 as the line, but without that, we can't scale beyond files in the base system. (This also poses a problem for out of tree kernel modules.) We might also want macros like the kernel, but I'm less sure of that.

kib added inline comments.Tue, Jul 7, 2:50 AM
lib/libthr/thread/thr_syscalls.c
664

Create a libc helper in the private version namespace that takes uexterrp, and call it there and in the libc' uexterr_set().

kib mentioned this in D58058: exterr: relax format restrictions.Tue, Jul 7, 2:52 AM
brooks added a parent revision: D58238: uexterr_gettext(3): support dynamic kernel categories.Tue, Jul 14, 8:10 PM
brooks updated this revision to Diff 182026.Wed, Jul 15, 8:31 AM

Add helper in libc. Tag categories as user space.

Harbormaster completed remote builds in B74824: Diff 182026.Wed, Jul 15, 8:31 AM
brooks marked an inline comment as done.Wed, Jul 15, 8:31 AM
kib accepted this revision.Sat, Jul 18, 1:45 PM
This revision is now accepted and ready to land.Sat, Jul 18, 1:45 PM
kib added inline comments.Sat, Jul 18, 1:45 PM
lib/libc/gen/uexterr_gettext.c
39

Stylistically, I do not see a need in this blank line, and in the blank line at 60.

brooks retitled this revision from runtime: add uexterr_set(3) to set errors in userspace to runtime: add the ability to set exterrors in userspace.Wed, Jul 22, 1:53 PM
brooks updated this revision to Diff 182455.Wed, Jul 22, 1:58 PM

Add UEXTERROR() analog to EXTERROR(). It differs in that it just wraps uexterr_set and thus it gets a different name.

This revision now requires review to proceed.Wed, Jul 22, 1:58 PM
Harbormaster completed remote builds in B75007: Diff 182455.Wed, Jul 22, 1:58 PM
brooks updated this revision to Diff 182464.Wed, Jul 22, 3:25 PM

Add docs. Make uexterr_set return void.

Herald added a subscriber: ziaee. · View Herald TranscriptWed, Jul 22, 3:25 PM
Harbormaster completed remote builds in B75013: Diff 182464.Wed, Jul 22, 3:25 PM
kib added inline comments.Wed, Jul 22, 9:53 PM
include/uexterror.h
9

I believe you need to add your copyright there and in other sources.

lib/libc/gen/uexterr_gettext.c
28

I think these functions should go into separate source file in libc. There is no reason to bring uexterror_set() into the static binary if only gettext() is used.

brooks updated this revision to Diff 182528.Thu, Jul 23, 3:00 PM
brooks marked 3 inline comments as done.

Move to its own file, document, update copyrights

Harbormaster completed remote builds in B75042: Diff 182528.Thu, Jul 23, 3:00 PM
brooks added inline comments.Thu, Jul 23, 3:00 PM
include/uexterror.h
9

Indeed, can we drop the All rights reserved.? The project doesn't want that in new copyrights.

brooks edited the summary of this revision. (Show Details)Thu, Jul 23, 3:01 PM
brooks added a child revision: D58413: uexterror_gettext: add tests for invalid formats.Thu, Jul 23, 3:04 PM
kib accepted this revision.Thu, Jul 23, 11:10 PM
kib added inline comments.
include/uexterror.h
9

Perhaps. Ask Ed, I used the header mandated by my contract.

lib/libc/gen/uexterr_gettext.c
13–14

To be perfect, this structure should go into a dedicated .c/.o as well.

This revision is now accepted and ready to land.Thu, Jul 23, 11:10 PM
brooks updated this revision to Diff 182596.Fri, Jul 24, 10:36 AM

Move global struct uexterror and constructor to its own file

This revision now requires review to proceed.Fri, Jul 24, 10:36 AM
Harbormaster completed remote builds in B75081: Diff 182596.Fri, Jul 24, 10:36 AM
brooks marked an inline comment as done.Fri, Jul 24, 10:53 AM
brooks added a subscriber: emaste.
brooks added inline comments.
include/uexterror.h
9

Tagging @emaste

kib added inline comments.Fri, Jul 24, 7:53 PM
lib/libc/gen/uexterror.3
129

Definitely not 15.0

brooks updated this revision to Diff 182764.Mon, Jul 27, 9:49 AM

Correct feature introduction to 16.0. Bump doc date.

Harbormaster completed remote builds in B75161: Diff 182764.Mon, Jul 27, 9:49 AM

Revision Contents
Changeset List

PathSize
include/
3 lines
65 lines
lib/
libc/
gen/
3 lines
2 lines
1 line
18 lines
uexterr_init.c
uexterr_gettext.c
19 lines
50 lines
135 lines
include/
6 lines
libthr/
thread/
13 lines
share/
man/
man9/
1 line

Diff 182596

View Options

include/Makefile

Loading...
View Options

include/uexterror.h

Loading...
View Options

lib/libc/gen/Makefile.inc

Loading...
View Options

lib/libc/gen/Symbol.map

Loading...
View Options

lib/libc/gen/libc_interposing_table.c

Loading...
View Options

lib/libc/gen/uexterr_gettext.c

Loading...
View Options

lib/libc/gen/uexterr_init.c

Loading...
View Options

lib/libc/gen/uexterr_set.c

Loading...
View Options

lib/libc/gen/uexterror.3

Loading...
View Options

lib/libc/include/libc_private.h

Loading...
View Options

lib/libthr/thread/thr_syscalls.c

Loading...
View Options

share/man/man9/exterror.9

Loading...