Differential D58060

exterr(9): add a few tests of new message formats
AcceptedPublic
Actions

Authored by brooks on Mon, Jul 6, 4:06 PM.

Tags

None

Referenced Files

	F164360892: D58060.diff
	Fri, Jul 31, 4:24 AM

	Unknown Object (File)
	Thu, Jul 30, 2:11 PM

	Unknown Object (File)
	Wed, Jul 29, 4:52 AM

	Unknown Object (File)
	Tue, Jul 28, 12:29 PM

	Unknown Object (File)
	Tue, Jul 28, 8:34 AM

	Unknown Object (File)
	Tue, Jul 28, 4:06 AM

	Unknown Object (File)
	Tue, Jul 28, 12:38 AM

	Unknown Object (File)
	Mon, Jul 27, 2:25 AM

View All 21 Files

Subscribers

Details

Reviewers

kib
mckusick

Group Reviewers

Summary

This is enough to show that the idea works (and to exercise
uexterr_set()), but isn't complete by any means.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75082
Build 71965: arc lint + arc unit

Event Timeline

brooks created this revision.Mon, Jul 6, 4:06 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 6, 4:06 PM

brooks requested review of this revision.Mon, Jul 6, 4:06 PM

Herald added a reviewer: cheri. · View Herald TranscriptMon, Jul 6, 4:06 PM

Harbormaster completed remote builds in B74553: Diff 181373.Mon, Jul 6, 4:06 PM

brooks added a parent revision: D58059: runtime: add the ability to set exterrors in userspace.Mon, Jul 6, 4:06 PM

Use UEXTERROR().

Harbormaster completed remote builds in B75008: Diff 182456.Wed, Jul 22, 1:59 PM

Update for UEXTERROR returning void.

Harbormaster completed remote builds in B75014: Diff 182465.Wed, Jul 22, 3:27 PM

kib accepted this revision.Wed, Jul 22, 9:46 PM

kib added inline comments.

tests/sys/kern/exterr_test.c
96	I am curious, what is the point of printing something out from ATF tests? Is it usable in some way?

This revision is now accepted and ready to land.Wed, Jul 22, 9:46 PM

brooks marked an inline comment as done.Thu, Jul 23, 8:41 AM

brooks added inline comments.

tests/sys/kern/exterr_test.c
96	When the tests fail the output ends up in the verbose reports and I've found it fairly useful when debugging these changes, especially in qemu VM where I don't have a compiler installed and don't want to build things by hand. That being said, the simple strcmp below should be a ATF_CHECK_STREQ which has the same effect.

Improve test description

This revision now requires review to proceed.Fri, Jul 24, 10:37 AM

Harbormaster completed remote builds in B75082: Diff 182597.Fri, Jul 24, 10:37 AM

kib accepted this revision.Fri, Jul 24, 8:24 PM

This revision is now accepted and ready to land.Fri, Jul 24, 8:24 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

34 lines

Diff 182597

tests/sys/kern/exterr_test.c

Loading...