Page MenuHomeFreeBSD
Differential D58236

exterr: split category into multiple sources
ClosedPublic
Actions

Authored by brooks on Jul 14 2026, 8:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 8, 6:32 PM
Unknown Object (File)
Sat, Aug 8, 5:28 PM
Unknown Object (File)
Sat, Aug 8, 5:24 PM
Unknown Object (File)
Wed, Aug 5, 10:03 PM
Unknown Object (File)
Wed, Aug 5, 10:03 PM
Unknown Object (File)
Wed, Aug 5, 9:19 PM
Unknown Object (File)
Wed, Aug 5, 8:49 PM
Unknown Object (File)
Mon, Aug 3, 2:26 PM
View All 34 Files
Subscribers
imp

Details

Reviewers
kib
mckusick
Commits
rGbbf95a9b8481: exterror(9): split category into multiple sources
Summary

The static, global index into an array of strings is simple, cheap,
and works for the base kernel, but is unworkable for (potentially
third-party) kernel modules or for arbitrary userspace code. Swipe a
couple of the top bits of category to indicate a source with all-zeros
being the current model (EXTERR_CAT_SRC_KERN_STATIC). Add two
additional sources EXTERR_CAT_SRC_KERN_DYNAMIC and EXTERR_CAT_SRC_USER
with stub implementations.

Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Jul 14 2026, 8:08 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 14 2026, 8:08 PM
brooks requested review of this revision.Jul 14 2026, 8:08 PM
Harbormaster completed remote builds in B74808: Diff 181996.Jul 14 2026, 8:08 PM
brooks added a parent revision: D58235: sys/exterrvar.h: forward declare struct thread.Jul 14 2026, 8:08 PM
brooks added a child revision: D58237: exterror(9): dynamic kernel categories.
kib added inline comments.Sat, Jul 18, 1:41 PM
sys/sys/exterr_cat.h
25

I suggest reserving more than 2 bits there. Otherwise I am fine.

brooks updated this revision to Diff 182293.Mon, Jul 20, 3:37 PM

Reserve 4 bits for sources (up from 2)

Harbormaster completed remote builds in B74956: Diff 182293.Mon, Jul 20, 3:37 PM
kib accepted this revision.Mon, Jul 20, 4:01 PM
This revision is now accepted and ready to land.Mon, Jul 20, 4:01 PM
brooks edited the summary of this revision. (Show Details)Thu, Jul 23, 2:48 PM
brooks added a child revision: D58412: kdump(1): minimally adapt to exterror category sources.Thu, Jul 23, 2:52 PM
Closed by commit rGbbf95a9b8481: exterror(9): split category into multiple sources (authored by brooks). · Explain WhyMon, Aug 3, 9:44 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGbbf95a9b8481: exterror(9): split category into multiple sources.

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
18 lines
sys/
sys/
12 lines

Diff 183341

View Options

lib/libc/gen/uexterr_format.c

Loading...
View Options

sys/sys/exterr_cat.h

Loading...