Page MenuHomeFreeBSD
Differential D58299

LinuxKPI: page.h: resort lines
ClosedPublic
Actions

Authored by bz on Fri, Jul 17, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 4, 4:03 AM
Unknown Object (File)
Mon, Aug 3, 1:16 PM
Unknown Object (File)
Sun, Aug 2, 6:21 PM
Unknown Object (File)
Sun, Aug 2, 8:43 AM
Unknown Object (File)
Sat, Aug 1, 6:22 PM
Unknown Object (File)
Sat, Aug 1, 10:41 AM
Unknown Object (File)
Fri, Jul 31, 9:00 AM
Unknown Object (File)
Fri, Jul 31, 7:07 AM
View All 30 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG7e06bfdd1489: LinuxKPI: page.h: resort lines
rG0b8d22019dcf: LinuxKPI: page.h: resort lines
Summary

Two of the "page macros" can be abstracted elsewhere in the upcoming
struct page work, so sort them away from the four which are here to
stay.

No functional change.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74909
Build 71792: arc lint + arc unit

Event Timeline

bz created this revision.Fri, Jul 17, 1:15 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptFri, Jul 17, 1:15 PM
bz requested review of this revision.Fri, Jul 17, 1:15 PM
Harbormaster completed remote builds in B74873: Diff 182119.Fri, Jul 17, 1:15 PM
bz added a parent revision: D58298: LinuxKPI: page.h: use atop() and ptoa() instead of PAGE_SHIFT.Fri, Jul 17, 1:18 PM
bz updated this revision to Diff 182169.Sat, Jul 18, 11:42 AM

REbase in the hope that with this the stack applies cleanly as well.

Harbormaster completed remote builds in B74909: Diff 182169.Sat, Jul 18, 11:42 AM
bz added a child revision: D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.Sat, Jul 18, 12:56 PM
bz added a comment.Wed, Jul 22, 6:06 PM

This will go in by Friday.

emaste accepted this revision.Wed, Jul 22, 8:39 PM

Sure. I think they could just stay where they are until the refactor but OK.

This revision is now accepted and ready to land.Wed, Jul 22, 8:39 PM
bz added a comment.Wed, Jul 22, 8:43 PM
In D58299#1339700, @emaste wrote:

Sure. I think they could just stay where they are until the refactor but OK.

depends on whether the "struct page' work goes in with the #ifdef at first or not in the end.
This makes the #ifdef simpler if you look at the 2nd half of https://reviews.freebsd.org/differential/changeset/?ref=1569038 and hopefully helps with reviewing those bits.

Closed by commit rG0b8d22019dcf: LinuxKPI: page.h: resort lines (authored by bz). · Explain WhyFri, Jul 24, 7:35 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG0b8d22019dcf: LinuxKPI: page.h: resort lines.
bz added a commit: rG7e06bfdd1489: LinuxKPI: page.h: resort lines.Mon, Jul 27, 12:11 AM
bz removed a child revision: D58320: LinuxKPI: Add PAGE_IS_LKPI_PAGE for Linux struct page instead of vm_page.Mon, Jul 27, 8:44 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
5 lines

Diff 182169

View Options

sys/compat/linuxkpi/common/include/linux/page.h

Loading...