Page MenuHomeFreeBSD
Differential D57520

netlink.4: Document missing socket options
ClosedPublic
Actions

Authored by zishun.yi.dev_gmail.com on Jun 10 2026, 8:36 AM.
Tags
None
Referenced Files
F165233458: D57520.id180776.diff
Fri, Aug 7, 1:30 AM
F165233456: D57520.id180700.diff
Fri, Aug 7, 1:30 AM
F165233454: D57520.id180678.diff
Fri, Aug 7, 1:30 AM
F165233453: D57520.id.diff
Fri, Aug 7, 1:30 AM
F165233452: D57520.id179549.diff
Fri, Aug 7, 1:30 AM
F165233420: D57520.diff
Fri, Aug 7, 1:30 AM
Unknown Object (File)
Mon, Aug 3, 2:01 AM
Unknown Object (File)
Sun, Aug 2, 6:06 AM
View All 71 Files
Subscribers
imp
obiwac
ziaee

Details

Reviewers
melifaro
ziaee
Group Reviewers
network
manpages
Commits
rG7fff1f194e07: netlink.4: Document missing socket options
Summary

Add descriptions for NETLINK_GET_STRICT_CHK, NETLINK_MSG_INFO.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74284
Build 71167: arc lint + arc unit

Event Timeline

zishun.yi.dev_gmail.com created this revision.Jun 10 2026, 8:36 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptJun 10 2026, 8:36 AM
zishun.yi.dev_gmail.com requested review of this revision.Jun 10 2026, 8:36 AM
zishun.yi.dev_gmail.com added a parent revision: D57519: netlink: Add sync path in user-kernel interface.
Harbormaster completed remote builds in B73794: Diff 179549.Jun 10 2026, 8:36 AM
zishun.yi.dev_gmail.com edited parent revisions, added: D57807: netlink: return ENOBUFS on RX overflow; removed: D57519: netlink: Add sync path in user-kernel interface.Jun 24 2026, 7:01 AM
obiwac added a subscriber: obiwac.Jun 24 2026, 1:30 PM
obiwac added inline comments.
share/man/man4/netlink.4
252
255–256

Let's just include this in the commit/revision where you add this flag

zishun.yi.dev_gmail.com abandoned this revision.Jun 25 2026, 9:57 AM
zishun.yi.dev_gmail.com removed a parent revision: D57807: netlink: return ENOBUFS on RX overflow.

Include this in the revision where I add this flag.

obiwac added a comment.Jun 26 2026, 3:20 AM
In D57520#1325996, @zishun.yi.dev_gmail.com wrote:

Include this in the revision where I add this flag.

well you could've still kept this revision open for NETLINK_GET_STRICT_CHK and NETLINK_MSG_INFO. That's still worthwhile

zishun.yi.dev_gmail.com reclaimed this revision.Jun 26 2026, 5:19 AM
zishun.yi.dev_gmail.com updated this revision to Diff 180678.Jun 26 2026, 5:19 AM
zishun.yi.dev_gmail.com marked 2 inline comments as done.

remove NETLINK_SND_SYNC.

Harbormaster completed remote builds in B74284: Diff 180678.Jun 26 2026, 5:20 AM
zishun.yi.dev_gmail.com added a child revision: D57519: netlink: Add sync path in user-kernel interface.Jun 26 2026, 5:20 AM
zishun.yi.dev_gmail.com edited the summary of this revision. (Show Details)Jun 26 2026, 5:27 AM
ziaee added inline comments.Jun 26 2026, 5:39 AM
share/man/man4/netlink.4
254

This is the only mention of cmsg on this page, should we be a bit more verbose?

zishun.yi.dev_gmail.com updated this revision to Diff 180700.Jun 26 2026, 11:57 AM
zishun.yi.dev_gmail.com marked an inline comment as done.

clarify cmsg

Harbormaster completed remote builds in B74291: Diff 180700.Jun 26 2026, 11:57 AM
obiwac added inline comments.Jun 26 2026, 12:35 PM
share/man/man4/netlink.4
254

missing space and this could use the .Pq macro, but fixable on commit

ziaee accepted this revision.Jun 26 2026, 6:04 PM
ziaee added a reviewer: manpages.

LGTM from manpages with @obiwac's suggestion! Thanks!

This revision is now accepted and ready to land.Jun 26 2026, 6:04 PM
Closed by commit rG7fff1f194e07: netlink.4: Document missing socket options (authored by zishun.yi.dev_gmail.com, committed by obiwac). · Explain WhyJun 26 2026, 6:41 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rG7fff1f194e07: netlink.4: Document missing socket options.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
4 lines

Diff 180678

View Options

share/man/man4/netlink.4

Loading...