Page MenuHomeFreeBSD
Differential D57520

netlink.4: Document missing socket options
ClosedPublic
Actions

Authored by zishun.yi.dev_gmail.com on Wed, Jun 10, 8:36 AM.
Tags
None
Referenced Files
F161411388: D57520.id180678.diff
Fri, Jul 3, 12:57 PM
Unknown Object (File)
Mon, Jun 29, 6:21 AM
Unknown Object (File)
Mon, Jun 29, 6:00 AM
Unknown Object (File)
Wed, Jun 24, 11:56 AM
Unknown Object (File)
Wed, Jun 24, 5:50 AM
Unknown Object (File)
Sun, Jun 21, 9:16 PM
Unknown Object (File)
Sat, Jun 20, 5:54 PM
Unknown Object (File)
Sat, Jun 20, 11:26 AM
View All 14 Files
Subscribers
imp
obiwac
ziaee

Details

Reviewers
melifaro
ziaee
Group Reviewers
network
manpages
Commits
rG7fff1f194e07: netlink.4: Document missing socket options
Summary

Add descriptions for NETLINK_GET_STRICT_CHK, NETLINK_MSG_INFO.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zishun.yi.dev_gmail.com created this revision.Wed, Jun 10, 8:36 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Jun 10, 8:36 AM
zishun.yi.dev_gmail.com requested review of this revision.Wed, Jun 10, 8:36 AM
zishun.yi.dev_gmail.com added a parent revision: D57519: netlink: Add sync path in user-kernel interface.
Harbormaster completed remote builds in B73794: Diff 179549.Wed, Jun 10, 8:36 AM
zishun.yi.dev_gmail.com edited parent revisions, added: D57807: netlink: return ENOBUFS on RX overflow; removed: D57519: netlink: Add sync path in user-kernel interface.Wed, Jun 24, 7:01 AM
obiwac added a subscriber: obiwac.Wed, Jun 24, 1:30 PM
obiwac added inline comments.
share/man/man4/netlink.4
252
255–256

Let's just include this in the commit/revision where you add this flag

zishun.yi.dev_gmail.com abandoned this revision.Thu, Jun 25, 9:57 AM
zishun.yi.dev_gmail.com removed a parent revision: D57807: netlink: return ENOBUFS on RX overflow.

Include this in the revision where I add this flag.

obiwac added a comment.Fri, Jun 26, 3:20 AM
In D57520#1325996, @zishun.yi.dev_gmail.com wrote:

Include this in the revision where I add this flag.

well you could've still kept this revision open for NETLINK_GET_STRICT_CHK and NETLINK_MSG_INFO. That's still worthwhile

zishun.yi.dev_gmail.com reclaimed this revision.Fri, Jun 26, 5:19 AM
zishun.yi.dev_gmail.com updated this revision to Diff 180678.Fri, Jun 26, 5:19 AM
zishun.yi.dev_gmail.com marked 2 inline comments as done.

remove NETLINK_SND_SYNC.

Harbormaster completed remote builds in B74284: Diff 180678.Fri, Jun 26, 5:20 AM
zishun.yi.dev_gmail.com added a child revision: D57519: netlink: Add sync path in user-kernel interface.Fri, Jun 26, 5:20 AM
zishun.yi.dev_gmail.com edited the summary of this revision. (Show Details)Fri, Jun 26, 5:27 AM
ziaee added inline comments.Fri, Jun 26, 5:39 AM
share/man/man4/netlink.4
254

This is the only mention of cmsg on this page, should we be a bit more verbose?

zishun.yi.dev_gmail.com updated this revision to Diff 180700.Fri, Jun 26, 11:57 AM
zishun.yi.dev_gmail.com marked an inline comment as done.

clarify cmsg

Harbormaster completed remote builds in B74291: Diff 180700.Fri, Jun 26, 11:57 AM
obiwac added inline comments.Fri, Jun 26, 12:35 PM
share/man/man4/netlink.4
254

missing space and this could use the .Pq macro, but fixable on commit

ziaee accepted this revision.Fri, Jun 26, 6:04 PM
ziaee added a reviewer: manpages.

LGTM from manpages with @obiwac's suggestion! Thanks!

This revision is now accepted and ready to land.Fri, Jun 26, 6:04 PM
Closed by commit rG7fff1f194e07: netlink.4: Document missing socket options (authored by zishun.yi.dev_gmail.com, committed by obiwac). · Explain WhyFri, Jun 26, 6:41 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rG7fff1f194e07: netlink.4: Document missing socket options.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
6 lines

Diff 180776

View Options

share/man/man4/netlink.4

Loading...