Page MenuHomeFreeBSD
Differential D57665

CHERI: add sooptcopyinptr to preserve pointer provenance
AcceptedPublic
Actions

Authored by brooks on Fri, Jun 19, 2:13 PM.
Tags
None
Referenced Files
F160443027: D57665.diff
Wed, Jun 24, 11:55 AM
F160426220: D57665.id180060.diff
Wed, Jun 24, 8:06 AM
F160426188: D57665.id180060.diff
Wed, Jun 24, 8:06 AM
F160412900: D57665.id180177.diff
Wed, Jun 24, 6:13 AM
F160373404: D57665.diff
Tue, Jun 23, 8:37 PM
Unknown Object (File)
Mon, Jun 22, 11:33 PM
Unknown Object (File)
Sat, Jun 20, 7:04 PM
Unknown Object (File)
Sat, Jun 20, 3:27 AM
Subscribers
emaste
glebius
imp
olce
ziaee

Details

Reviewers
kib
markj
jhb
jrtc27
Group Reviewers
cheri
Summary

Most socket options don't involve pointers so make the default
sooptcopyin discard provenance and add a sooptcopyinptr that preserves.

Effort: CHERI upstreaming
Sponsored by: DARPA, AFRL, Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74000
Build 70883: arc lint + arc unit

Event Timeline

brooks created this revision.Fri, Jun 19, 2:13 PM
Herald added subscribers: ziaee, olce, glebius, imp. · View Herald TranscriptFri, Jun 19, 2:13 PM
brooks requested review of this revision.Fri, Jun 19, 2:13 PM
Herald added a reviewer: cheri. · View Herald TranscriptFri, Jun 19, 2:13 PM
brooks added a parent revision: D57664: CHERI: declare fueptr and suptr.Fri, Jun 19, 2:13 PM
Harbormaster completed remote builds in B74000: Diff 180060.Fri, Jun 19, 2:13 PM
brooks updated this revision to Diff 180177.Sat, Jun 20, 5:12 PM

use memcpy_data

Harbormaster completed remote builds in B74066: Diff 180177.Sat, Jun 20, 5:12 PM
brooks updated this revision to Diff 180520.Wed, Jun 24, 10:09 AM

Link manpages to the description of pointer provenance in arch(7)

Harbormaster completed remote builds in B74197: Diff 180520.Wed, Jun 24, 10:09 AM
markj accepted this revision as: markj.Wed, Jun 24, 1:41 PM
This revision is now accepted and ready to land.Wed, Jun 24, 1:41 PM
emaste added a subscriber: emaste.Wed, Jun 24, 1:45 PM
emaste added inline comments.
share/man/man9/socket.9
589

Should we strengthen this somewhat, e.g. "no consumers exist or are anticipated"? Is it "we didn't do this because nobody needs it now" or "we don't think this really makes sense". Given that we generally pass in buffers for the kernel to populate the latter is probably the case?

Revision Contents
Changeset List

PathSize
share/
man/
man9/
11 lines
sys/
kern/
34 lines
sys/
6 lines

Diff 180060

View Options

share/man/man9/socket.9

Loading...
View Options

sys/kern/uipc_socket.c

Loading...
View Options

sys/sys/sockopt.h

Loading...