Page MenuHomeFreeBSD
Differential D57405

libc: fix strtold NaN representation on riscv
ClosedPublic
Actions

Authored by siva on Wed, Jun 3, 3:31 PM.
Tags
None
Referenced Files
F160283238: D57405.id179590.diff
Mon, Jun 22, 10:18 PM
F160282884: D57405.id179590.diff
Mon, Jun 22, 10:12 PM
Unknown Object (File)
Sun, Jun 21, 5:28 AM
Unknown Object (File)
Sun, Jun 21, 5:23 AM
Unknown Object (File)
Sat, Jun 20, 2:13 PM
Unknown Object (File)
Sat, Jun 20, 11:43 AM
Unknown Object (File)
Fri, Jun 19, 3:17 AM
Unknown Object (File)
Fri, Jun 19, 3:14 AM
View All 27 Files
Subscribers
br
imp

Details

Reviewers
emaste
lwhsu
fuz
jrtc27
brooks
Group Reviewers
riscv
Commits
rG1e25cda7f069: libc: fix strtold NaN representation on riscv
Summary

Regenerate gd_qnan.h on riscv using the qnan.c
config tool found in contrib/gdtoa.

This fixes the following tests in CI:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16612/testReport/lib.libc.stdio/scanfloat_test/infinities_and_nans/
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16612/testReport/lib.libc.stdlib/strtod_test/strtold_nan/

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73636
Build 70519: arc lint + arc unit

Event Timeline

siva created this revision.Wed, Jun 3, 3:31 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 3, 3:31 PM
siva requested review of this revision.Wed, Jun 3, 3:31 PM
Harbormaster completed remote builds in B73636: Diff 179129.Wed, Jun 3, 3:31 PM
fuz added reviewers: jrtc27, brooks, riscv.Wed, Jun 3, 5:33 PM
jrtc27 accepted this revision.Wed, Jun 3, 5:48 PM

Hm, seems the current version is the same as the arm file, and now it's the same as the aarch64 one? I'm guessing copying from arm is how this came to be...

Please trim the URLs from the commit message and just mention the test names though, they're a bit long and cumbersome otherwise

This revision is now accepted and ready to land.Wed, Jun 3, 5:48 PM
br added a subscriber: br.Wed, Jun 3, 6:07 PM
In D57405#1315493, @jrtc27 wrote:

Hm, seems the current version is the same as the arm file, and now it's the same as the aarch64 one? I'm guessing copying from arm is how this came to be...

Looks like arm's gd_qnan.h was also regenerated recently. So not sure where I got this one from :)

Closed by commit rG1e25cda7f069: libc: fix strtold NaN representation on riscv (authored by siva). · Explain WhyWed, Jun 10, 11:32 PM
This revision was automatically updated to reflect the committed changes.
siva added a commit: rG1e25cda7f069: libc: fix strtold NaN representation on riscv.

Revision Contents
Changeset List

PathSize
lib/
libc/
riscv/
6 lines

Diff 179129

View Options

lib/libc/riscv/gd_qnan.h

Loading...