vmm: Move defines from x86.c to x86/bhyve.h
ClosedPublic
Actions

Authored by cperciva on Feb 22 2026, 4:11 AM.

Details

Reviewers

kib

Group Reviewers

bhyve

Commits

rG075909e9faed: vmm: Move defines from x86.c to x86/bhyve.h
rG7d44ef361055: vmm: Move defines from x86.c to x86/bhyve.h
rG49b6254b3e09: vmm: Move defines from x86.c to x86/bhyve.h

Summary

The values CPUID_BHYVE_FEATURES and CPUID_BHYVE_FEAT_EXT_DEST_ID are
useful for guests, not just hosts; so they belong in a header file in
sys/x86/include rather than simply in the .c file implementing the
bhyve host side.

The original addition of these defines took place without adding a
copyright statement, but since I'm moving them into a new file I've
added the original author's standard copyright (Amazon).

MFC after: 2 weeks
Fixes: 313a68ea20b4 ("bhyve: Add CPUID_BHYVE_FEATURES leaf")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Feb 22 2026, 4:11 AM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 22 2026, 4:11 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

cperciva requested review of this revision.Feb 22 2026, 4:11 AM

Harbormaster completed remote builds in B70869: Diff 172429.Feb 22 2026, 4:11 AM

cperciva added a parent revision: D55429: Xen: Detect Extended Destination ID support.Feb 22 2026, 4:11 AM

cperciva added a child revision: D55431: Bhyve: Detect Extended Destination ID support.

cperciva added a reviewer: kib.Feb 22 2026, 4:15 AM

Adjusted include guard to _X86_BHYVE_H_ instead of _BHYVE_H_

Harbormaster completed remote builds in B70901: Diff 172484.Feb 23 2026, 6:00 AM

Perhaps the defines should go into x86/include/specialreg.h together with all other CPUID bits definitions.

In D55430#1268961, @kib wrote:

Perhaps the defines should go into x86/include/specialreg.h together with all other CPUID bits definitions.

I considered that, but specialreg.h only has CPUID bits relating to hardware; hypervisor-related CPUID bits have always gone into hypervisor-specific header files.

IMO other bits should be also moved to specialreg.h

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2026, 5:57 AM

Closed by commit rG49b6254b3e09: vmm: Move defines from x86.c to x86/bhyve.h (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG49b6254b3e09: vmm: Move defines from x86.c to x86/bhyve.h.

cperciva added a commit: rG7d44ef361055: vmm: Move defines from x86.c to x86/bhyve.h.Apr 16 2026, 3:05 PM

cperciva added a commit: rG075909e9faed: vmm: Move defines from x86.c to x86/bhyve.h.Apr 16 2026, 3:12 PM