Paths

Table of Contentst

Differential D55949

arm64: Support changing the DMAP memory type
Needs ReviewPublic
Actions

Authored by andrew on Thu, Mar 19, 4:05 PM.

Tags

None

Referenced Files

	F149525648: D55949.diff
	Wed, Mar 25, 12:51 AM

	Unknown Object (File)
	Tue, Mar 24, 7:16 AM

	Unknown Object (File)
	Tue, Mar 24, 5:45 AM

	Unknown Object (File)
	Tue, Mar 24, 4:03 AM

	Unknown Object (File)
	Tue, Mar 24, 1:50 AM

	Unknown Object (File)
	Sun, Mar 22, 11:25 PM

	Unknown Object (File)
	Sat, Mar 21, 11:31 AM

Subscribers

Details

Reviewers

manu
alc
kib
markj

Group Reviewers

Summary

When MTE is enabled we will use the DMAP to manage tags. To be able to
read/write them we need to change the memory attribute to
VM_MEMATTR_TAGGED.

Support changing the DMAP memory type to values known to have
equivalent cache properties.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71530
Build 68413: arc lint + arc unit

Event Timeline

andrew created this revision.Thu, Mar 19, 4:05 PM

Herald added a reviewer: manu. · View Herald TranscriptThu, Mar 19, 4:05 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Thu, Mar 19, 4:05 PM

Harbormaster completed remote builds in B71530: Diff 173919.Thu, Mar 19, 4:05 PM

andrew added a parent revision: D55948: arm64: mte: add tagged memory attribute.Thu, Mar 19, 4:05 PM

andrew added a child revision: D55950: arm64: Support some per-thread sctlr_el1 fields.

andrew added reviewers: alc, kib, markj.Thu, Mar 19, 4:25 PM

markj added inline comments.Mon, Mar 23, 2:10 AM

sys/arm64/arm64/pmap.c
8310	Please update this comment.
8438	Can the comment please explain why this is necessary?
8450	Suppose we update a range with `mode == VM_MEMATTR_WRITE_BACK`, and `dmap_attr != VM_MEMATTR_WRITE_BACK`. Then, a subsequent update of the same range with `old_mode == VM_MEMATTR_WRITE_BACK` will not update the DMAP entries, which seems like a bug.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

55 lines

include/

1 line

Diff 173919

sys/arm64/arm64/pmap.c

Loading...

sys/arm64/include/pmap.h

Loading...