Differential D55895

pkg-serve(8): serve pkg repositories over TCP via inetd
ClosedPublic
Actions

Authored by bapt on Tue, Mar 17, 11:04 AM.

Tags

None

Referenced Files

	F149451260: D55895.id173800.diff
	Tue, Mar 24, 1:36 PM

	F149415632: D55895.id173804.diff
	Tue, Mar 24, 7:56 AM

	F149403029: D55895.id174001.diff
	Tue, Mar 24, 5:46 AM

	Unknown Object (File)
	Mon, Mar 23, 7:15 AM

	Unknown Object (File)
	Mon, Mar 23, 12:22 AM

	Unknown Object (File)
	Sun, Mar 22, 8:45 AM

	Unknown Object (File)
	Sun, Mar 22, 6:17 AM

	Unknown Object (File)
	Sat, Mar 21, 10:52 PM

View All 10 Files

Subscribers

Details

Reviewers

manu
bdrewery

Commits

rGb42e852e89cb: pkg-serve(8): serve pkg repositories over TCP via inetd (8)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71455
Build 68338: arc lint + arc unit

Event Timeline

bapt created this revision.Tue, Mar 17, 11:04 AM

Herald added subscribers: ivy, ziaee, jonathan, imp. · View Herald TranscriptTue, Mar 17, 11:04 AM

Harbormaster completed remote builds in B71454: Diff 173800.Tue, Mar 17, 11:04 AM

bapt requested review of this revision.Tue, Mar 17, 11:04 AM

manu accepted this revision.Tue, Mar 17, 12:29 PM

manu added a subscriber: manu.

manu added inline comments.

libexec/pkg-serve/pkg-serve.8
2	s/6/2026/

This revision is now accepted and ready to land.Tue, Mar 17, 12:29 PM

fix copyright

This revision now requires review to proceed.Tue, Mar 17, 12:41 PM

Harbormaster completed remote builds in B71455: Diff 173804.Tue, Mar 17, 12:41 PM

bapt marked an inline comment as done.Tue, Mar 17, 12:41 PM

bms added a subscriber: bms.Tue, Mar 17, 1:21 PM

Nice work

libexec/pkg-serve/pkg-serve.c
175–176	Resources get cleaned up on successful exit but not on setup errors.

This revision is now accepted and ready to land.Tue, Mar 17, 3:38 PM

ivy added inline comments.Tue, Mar 17, 11:13 PM

libexec/pkg-serve/pkg-serve.c
133	is this actually necessary if it's running under Capsicum? it could flag on some legitimate files, depending on what people are using it for.
167	this will write too much data if the file grows in size while writing. probably it needs to track total size and indicate some sort of protocol error if the file is larger than expected.

ivy added inline comments.Tue, Mar 17, 11:15 PM

libexec/Makefile
17	imo, this is preferable: SUBDIR.${MK_PKGSERVE}+= pkgserve this is the syntax we've been using for man, confs, etc., and it's much easier to read.

i wonder: why is this in base, when pkg repository can only be built when pkg(8) is installed?

Address ivy's comment

This revision now requires review to proceed.Fri, Mar 20, 8:31 AM

Harbormaster completed remote builds in B71581: Diff 173999.Fri, Mar 20, 8:31 AM

Address bdrewery's comments

Harbormaster completed remote builds in B71583: Diff 174001.Fri, Mar 20, 8:54 AM

bapt marked 4 inline comments as done.Fri, Mar 20, 8:55 AM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Mar 20, 12:33 PM

Closed by commit rGb42e852e89cb: pkg-serve(8): serve pkg repositories over TCP via inetd (8) (authored by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rGb42e852e89cb: pkg-serve(8): serve pkg repositories over TCP via inetd (8).

Herald added a subscriber: emaste. · View Herald TranscriptFri, Mar 20, 12:33 PM

Revision Contents
Changeset List

Path

Size

etc/

mtree/

2 lines

libexec/

5 lines

pkg-serve/

9 lines

107 lines

179 lines

tests/

5 lines

pkg_serve_test.sh

230 lines

tools/

build/

options/

WITHOUT_PKGSERVE

2 lines

Diff 173804

etc/mtree/BSD.tests.dist

Loading...

libexec/Makefile

Loading...

libexec/pkg-serve/Makefile

Loading...

libexec/pkg-serve/pkg-serve.8

Loading...

libexec/pkg-serve/pkg-serve.c

Loading...

libexec/pkg-serve/tests/Makefile

Loading...

libexec/pkg-serve/tests/pkg_serve_test.sh

Loading...

tools/build/options/WITHOUT_PKGSERVE

Loading...