Page MenuHomeFreeBSD
Differential D55561

acpi: Treat ACPI_IVAR_FLAGS as a global IVAR
ClosedPublic
Actions

Authored by jhb on Feb 27 2026, 3:52 PM.
Tags
None
Referenced Files
F163162084: D55561.diff
Mon, Jul 20, 3:56 PM
Unknown Object (File)
Sat, Jul 18, 10:23 AM
Unknown Object (File)
Thu, Jul 16, 10:53 AM
Unknown Object (File)
Wed, Jul 15, 7:10 AM
Unknown Object (File)
Wed, Jul 15, 7:10 AM
Unknown Object (File)
Sat, Jul 4, 3:46 AM
Unknown Object (File)
Jun 10 2026, 12:42 PM
Unknown Object (File)
Jun 7 2026, 3:28 PM
View All 51 Files
Subscribers
None

Details

Reviewers
imp
jkim
ngie
Commits
rG00ff89c1e0c8: acpi: Treat ACPI_IVAR_FLAGS as a global IVAR
Summary

The ACPI bus uses the flags IVAR for any device with a _PRW method
including devices such as PCI bridges/devices that are not direct
children of acpi0.

Reported by: ngie
Fixes: 0bb867e9f565 ("acpi: Split ACPI IVARs into global and private sets")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71067
Build 67950: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Feb 27 2026, 3:52 PM
jhb created this revision.
jhb added a child revision: D55562: acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR.
Harbormaster completed remote builds in B71067: Diff 172868.Feb 27 2026, 3:53 PM
ngie accepted this revision.EditedFeb 27 2026, 7:51 PM

LGTM. This also helped get my MBP13,1 back into a state where it no longer panicked running sysctl dev.pci. Does this complement D55562?

This revision is now accepted and ready to land.Feb 27 2026, 7:51 PM
Closed by commit rG00ff89c1e0c8: acpi: Treat ACPI_IVAR_FLAGS as a global IVAR (authored by jhb). · Explain WhyMar 4 2026, 8:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG00ff89c1e0c8: acpi: Treat ACPI_IVAR_FLAGS as a global IVAR.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
4 lines

Diff 172868

View Options

sys/dev/acpica/acpivar.h

Loading...