rge: fix callout setup/teardown; handle invalid ethernet address
ClosedPublic
Actions

Authored by adrian on Sat, Feb 21, 7:44 PM.

Details

Reviewers

imp
zlei

Group Reviewers

network

Commits

rGd5ca52182e52: rge: fix callout setup/teardown; handle invalid ethernet address

Summary

Do the callout init early; since some of the teardown path expects the callout to be valid

Handle an invalid ethernet address by generating a local one.

PR: kern/293307

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70856
Build 67739: arc lint + arc unit

Event Timeline

adrian created this revision.Sat, Feb 21, 7:44 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Feb 21, 7:44 PM

adrian requested review of this revision.Sat, Feb 21, 7:44 PM

Harbormaster completed remote builds in B70856: Diff 172393.Sat, Feb 21, 7:44 PM

adrian added a child revision: D55420: rge: correctly free busdma memory / zero things out only if allocated.Sat, Feb 21, 7:44 PM

adrian added reviewers: network, imp.Sat, Feb 21, 8:07 PM

adrian added a project: network.

Looks good to me.

This revision is now accepted and ready to land.Sun, Feb 22, 3:26 AM

Closed by commit rGd5ca52182e52: rge: fix callout setup/teardown; handle invalid ethernet address (authored by • john.darrah09_gmail.com, committed by adrian). · Explain WhySun, Feb 22, 6:08 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGd5ca52182e52: rge: fix callout setup/teardown; handle invalid ethernet address.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rge/

if_rge.c

19 lines

Diff 172393

View Options

rge: fix callout setup/teardown; handle invalid ethernet addressClosedPublicActions