Paths

Table of Contentst

Differential D55728

rge: handle interface flags changes
ClosedPublic
Actions

Authored by brad_comstyle.com on Sun, Mar 8, 12:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 24, 5:03 PM

	Unknown Object (File)
	Thu, Mar 19, 1:48 PM

	Unknown Object (File)
	Thu, Mar 19, 7:55 AM

	Unknown Object (File)
	Thu, Mar 19, 5:42 AM

	Unknown Object (File)
	Tue, Mar 17, 2:29 AM

	Unknown Object (File)
	Mon, Mar 16, 9:17 PM

	Unknown Object (File)
	Sun, Mar 15, 8:33 PM

	Unknown Object (File)
	Sun, Mar 15, 6:25 PM

View All 11 Files

Subscribers

Details

Reviewers

adrian
zlei

Group Reviewers

Commits

rGf7fd4e79fa09: rge: handle interface flags changes

Summary

Handle interface flags like other drivers do.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brad_comstyle.com created this revision.Sun, Mar 8, 12:21 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Mar 8, 12:21 PM

brad_comstyle.com requested review of this revision.Sun, Mar 8, 12:21 PM

Ok, i'm now actively looking at this.

adrian accepted this revision.Sun, Mar 22, 3:38 PM

This revision is now accepted and ready to land.Sun, Mar 22, 3:38 PM

I do not have hardware to test this change, but the code looks good to me.

sys/dev/rge/if_rge.c
961	I'd recommend to stash `if_getflags(ifp)`. Currently the net stack does not have proper sync of the ifnet flags. If other threads are modifying it concurrently, then the driver may be in inconsistent state.

Closed by commit rGf7fd4e79fa09: rge: handle interface flags changes (authored by brad_comstyle.com, committed by adrian). · Explain WhyWed, Mar 25, 1:30 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGf7fd4e79fa09: rge: handle interface flags changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rge/

21 lines

2 lines

Diff 174257

sys/dev/rge/if_rge.c

Loading...

sys/dev/rge/if_rgevar.h

Loading...