Paths

Table of Contentst

rge: handle interface flags changes
ClosedPublic
Actions

Authored by brad_comstyle.com on Mar 8 2026, 12:21 PM.

Tags

None

Referenced Files

	F157356736: D55728.diff
	Wed, May 20, 2:11 PM

	Unknown Object (File)
	Mon, May 18, 11:33 AM

	Unknown Object (File)
	Mon, May 18, 11:25 AM

	Unknown Object (File)
	Mon, May 18, 10:23 AM

	Unknown Object (File)
	Mon, May 18, 10:20 AM

	Unknown Object (File)
	Fri, May 15, 4:53 PM

	Unknown Object (File)
	Sun, May 3, 1:30 PM

	Unknown Object (File)
	Sat, May 2, 12:25 PM

View All 24 Files

Subscribers

imp

zlei

Details

Reviewers

adrian
zlei

Group Reviewers

network

Commits

rGf7fd4e79fa09: rge: handle interface flags changes

Summary

Handle interface flags like other drivers do.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brad_comstyle.com created this revision.Mar 8 2026, 12:21 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 8 2026, 12:21 PM

brad_comstyle.com requested review of this revision.Mar 8 2026, 12:21 PM

@adrian Ping.

Ok, i'm now actively looking at this.

adrian accepted this revision.Mar 22 2026, 3:38 PM

This revision is now accepted and ready to land.Mar 22 2026, 3:38 PM

I do not have hardware to test this change, but the code looks good to me.

sys/dev/rge/if_rge.c
961	I'd recommend to stash `if_getflags(ifp)`. Currently the net stack does not have proper sync of the ifnet flags. If other threads are modifying it concurrently, then the driver may be in inconsistent state.

Closed by commit rGf7fd4e79fa09: rge: handle interface flags changes (authored by brad_comstyle.com, committed by adrian). · Explain WhyMar 25 2026, 1:30 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGf7fd4e79fa09: rge: handle interface flags changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rge/

if_rge.c

21 lines

if_rgevar.h

2 lines

Diff 174257

View Options

sys/dev/rge/if_rge.c