Page MenuHomeFreeBSD
Differential D54918

ifconfig: Report errors from failed FIB commands
ClosedPublic
Actions

Authored by markj on Jan 27 2026, 6:32 PM.
Tags
None
Referenced Files
F162958523: D54918.diff
Sat, Jul 18, 5:08 PM
Unknown Object (File)
Fri, Jul 17, 8:09 PM
Unknown Object (File)
Wed, Jul 15, 7:04 AM
Unknown Object (File)
Wed, Jul 15, 7:04 AM
Unknown Object (File)
Jun 18 2026, 12:09 PM
Unknown Object (File)
Jun 16 2026, 8:23 AM
Unknown Object (File)
Jun 14 2026, 12:39 PM
Unknown Object (File)
Jun 13 2026, 12:47 AM
View All 43 Files
Subscribers
imp
melifaro
pouria
zlei

Details

Reviewers
pouria
zlei
melifaro
Group Reviewers
network
Commits
rGd4763c1fe5bc: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails
rG147873a1a7d8: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails
rG2ea85a622bcb: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails
Summary

Previously, setting an interface FIB to some invalid value would result
in a warning being printed, but the ifconfig command would exit with
status 0, but this seems wrong.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70171
Build 67054: arc lint + arc unit

Event Timeline

markj created this revision.Jan 27 2026, 6:32 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 27 2026, 6:32 PM
markj requested review of this revision.Jan 27 2026, 6:32 PM
Harbormaster completed remote builds in B70171: Diff 170547.Jan 27 2026, 6:32 PM
pouria accepted this revision as: pouria.Jan 27 2026, 9:20 PM
pouria added a subscriber: pouria.

LGTM

This revision is now accepted and ready to land.Jan 27 2026, 9:20 PM
zlei accepted this revision as: zlei.Jan 28 2026, 3:20 AM
zlei added a subscriber: zlei.

Looks good to me.

zlei added a subscriber: melifaro.Jan 28 2026, 3:28 AM
zlei added inline comments.
sbin/ifconfig/iffib.c
97

CC the author @melifaro to see if the warn() is intentional .

melifaro accepted this revision.Jan 28 2026, 11:27 AM
Closed by commit rG2ea85a622bcb: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails (authored by markj). · Explain WhyJan 28 2026, 4:14 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG2ea85a622bcb: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails.
markj added a commit: rG147873a1a7d8: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails.Feb 16 2026, 3:44 PM
markj added a commit: rGd4763c1fe5bc: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails.Feb 16 2026, 7:47 PM

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
16 lines
tests/
3 lines
32 lines

Diff 170547

View Options

sbin/ifconfig/iffib.c

Loading...
View Options

sbin/ifconfig/tests/Makefile

Loading...
View Options

sbin/ifconfig/tests/ifconfig.sh

Loading...