Page MenuHomeFreeBSD

acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description
AcceptedPublic

Authored by olce on Fri, Jan 9, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 25, 7:35 AM
Unknown Object (File)
Fri, Jan 23, 7:27 PM
Unknown Object (File)
Wed, Jan 21, 10:10 AM
Unknown Object (File)
Wed, Jan 21, 1:50 AM
Unknown Object (File)
Fri, Jan 16, 12:47 AM
Unknown Object (File)
Sun, Jan 11, 10:10 AM
Unknown Object (File)
Sat, Jan 10, 12:52 AM
Unknown Object (File)
Fri, Jan 9, 10:21 PM
Subscribers

Details

Reviewers
obiwac
jhb
Summary

Another boolean, indicating hardware support, will be introduced along
it in next commit.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69769
Build 66652: arc lint + arc unit

Event Timeline

olce requested review of this revision.Fri, Jan 9, 5:09 PM

I'm not too sure about changing the type of a sysctl knob that has existed for a long time. The only compatibility problem that I can see doing this is potentially breaking reporting in an application that would call sysctl(3) (or sysctlbyname(3)) directly, passing an unitialized integer and then reading from it, as only the first byte would have been filled. Setting the boolean would still work (except on big-endian arches). The use of an old sysctl(8) utility is not affected.

If you feel that's not OK, I could change that part of the commit if necessary, introducing a specific handler to paper over the difference between the sysctl knob type and the field's one.

Accepting assuming no one has objections about changing the size of the sysctl

This revision is now accepted and ready to land.Fri, Jan 9, 7:19 PM