Page MenuHomeFreeBSD
Differential D52705

acpi: Use sleep types defined in sys/power.h
ClosedPublic
Actions

Authored by obiwac on Sep 24 2025, 11:42 AM.
Tags
None
Referenced Files
F157549751: D52705.id162731.diff
Fri, May 22, 5:32 PM
F157546411: D52705.diff
Fri, May 22, 4:38 PM
Unknown Object (File)
Tue, May 19, 8:37 PM
Unknown Object (File)
Mon, May 18, 12:15 PM
Unknown Object (File)
Mon, May 18, 12:08 PM
Unknown Object (File)
Sat, May 16, 7:30 AM
Unknown Object (File)
Fri, May 15, 6:13 AM
Unknown Object (File)
Thu, May 14, 12:55 AM
View All Files
Subscribers
cy

Details

Reviewers
markj
jkim
jhb
emaste
imp
cy
Commits
rG97d152698f48: acpi: Use sleep types defined in sys/power.h
Summary

This is as opposed to using ACPI sleep states directly
(ACPI_STATE_S*). We now use POWER_STYPE_* added in D52036.

This is in preparation for adding support for s2idle, which is not an
ACPI sleep state, but needs to be handled specially by
acpi_EnterSleepState.

These are the changes in D52043 + the fixes in D52545 and D52598 already applied.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67273
Build 64156: arc lint + arc unit

Event Timeline

obiwac requested review of this revision.Sep 24 2025, 11:42 AM
obiwac created this revision.
Harbormaster completed remote builds in B67272: Diff 162722.Sep 24 2025, 11:42 AM
obiwac added a child revision: D52600: acpi: Add back `hw.acpi.suspend_state` sysctl.Sep 24 2025, 11:43 AM
obiwac mentioned this in D52598: acpi: Fix panic on poweroff.
obiwac updated this revision to Diff 162723.Sep 24 2025, 11:47 AM

fixes from review comment in D52598

Harbormaster completed remote builds in B67273: Diff 162723.Sep 24 2025, 11:47 AM
obiwac mentioned this in D51591: linuxkpi: Support s2idle in `pm_suspend_target_state`.Sep 24 2025, 12:18 PM
obiwac added a child revision: D51591: linuxkpi: Support s2idle in `pm_suspend_target_state`.Sep 24 2025, 12:18 PM
obiwac added a child revision: D48734: acpi: Suspend-to-idle support (s2idle).
obiwac updated this revision to Diff 162731.Sep 24 2025, 1:27 PM

Fix S3 suspend.

Harbormaster completed remote builds in B67276: Diff 162731.Sep 24 2025, 1:27 PM
cy accepted this revision.Sep 24 2025, 4:51 PM
cy added a subscriber: cy.

Works.

This revision is now accepted and ready to land.Sep 24 2025, 4:51 PM
obiwac added a child revision: D52727: sys/power: Sleep type reporting by PM backends.Sep 25 2025, 9:51 AM
Closed by commit rG97d152698f48: acpi: Use sleep types defined in sys/power.h (authored by obiwac). · Explain WhySep 26 2025, 4:04 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rG97d152698f48: acpi: Use sleep types defined in sys/power.h.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
382 lines
4 lines
15 lines
x86/
acpica/
25 lines

Diff 162723

View Options

sys/dev/acpica/acpi.c

Loading...
View Options

sys/dev/acpica/acpi_lid.c

Loading...
View Options

sys/dev/acpica/acpivar.h

Loading...
View Options

sys/x86/acpica/acpi_apm.c

Loading...