Details

Reviewers

glebius
zlei
kevans
markj

Group Reviewers

bhyve

Commits

rG626cf6c8fcff: bhyve: add support for ng_device network backend
rG1aad95345237: bhyve: add support for ng_device network backend

Summary

Signed-off-by: Quentin Thébault <quentin.thebault@defenso.fr>
Sponsored by: Defenso

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67161
Build 64044: arc lint + arc unit

Event Timeline

quentin.thebault_defenso.fr created this revision.Sep 15 2025, 3:58 AM

Herald added a reviewer: bhyve. · View Herald TranscriptSep 15 2025, 3:58 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

quentin.thebault_defenso.fr requested review of this revision.Sep 15 2025, 3:58 AM

Harbormaster completed remote builds in B67034: Diff 162040.Sep 15 2025, 3:58 AM

quentin.thebault_defenso.fr added a parent revision: D52541: ng_device: add kqueue support.Sep 15 2025, 3:58 AM

The bhyve.8 man page needs to be updated to mention the new backend.

usr.sbin/bhyve/net_backends.c
123	The `&&` should be on the previous line.

Added bhyve.8 changes and fixed if syntax.

Herald added a subscriber: ziaee. · View Herald TranscriptSep 16 2025, 2:14 AM

Harbormaster completed remote builds in B67069: Diff 162127.Sep 16 2025, 2:14 AM

quentin.thebault_defenso.fr marked an inline comment as done.Sep 16 2025, 2:16 AM

quentin.thebault_defenso.fr added inline comments.

usr.sbin/bhyve/net_backends.c
123	Done, thank you.

Removed superfluous Xo and Xc in bhyve.8

Harbormaster completed remote builds in B67070: Diff 162128.Sep 16 2025, 2:20 AM

tap_init() will open the device and add it to the mevent loop, which uses kevent() under the hood. But, ng_device doesn't implement d_kqfilter, i.e., ngd_cdevsw doesn't have a d_kqfilter implementation, in contrast with tap devices. How does bhyve know when to read packets from the device?

usr.sbin/bhyve/bhyve.8
551	New sentences should start on new lines.

In D52542#1201906, @markj wrote:

tap_init() will open the device and add it to the mevent loop, which uses kevent() under the hood. But, ng_device doesn't implement d_kqfilter, i.e., ngd_cdevsw doesn't have a d_kqfilter implementation, in contrast with tap devices. How does bhyve know when to read packets from the device?

Please have a look at parent revision D52541, which adds kevent support to ng_device.

In D52542#1201909, @quentin.thebault_defenso.fr wrote:

In D52542#1201906, @markj wrote:

tap_init() will open the device and add it to the mevent loop, which uses kevent() under the hood. But, ng_device doesn't implement d_kqfilter, i.e., ngd_cdevsw doesn't have a d_kqfilter implementation, in contrast with tap devices. How does bhyve know when to read packets from the device?

Please have a look at parent revision D52541, which adds kevent support to ng_device.