Details

sys/netgraph/ng_device.c
156	Indentation here looks wrong.
337	Why do you need to lock earlier here?
537–538	You are missing braces here...
547	Same here.
676	Please fix the indentation in these functions. See the style(9) manual page.

Fix braces, indentation, restore original lock and set VNET

The VNET fix in ngdwrite was necessary to avoid a panic in
ng_ID2noderef (ng_base.c) when the ng_device is connected to
an ng_bridge node.

Harbormaster completed remote builds in B67249: Diff 162603.Sep 23 2025, 2:20 AM

quentin.thebault_defenso.fr added inline comments.Sep 24 2025, 3:02 PM

sys/netgraph/ng_device.c
241	These must be destroyed before the mutex they use.
381	To be destroyed before mutex.

Clean up device destruction

Fix order of knlist_destroy() and mtx_destroy()
Call knlist_clear() before knlist_destroy()
Add NGDF_DYING flag to send off the reader properly
Reverted unnecessary mtx changes in ngdread()

Harbormaster completed remote builds in B67295: Diff 162787.Sep 25 2025, 3:03 AM

Remove superflous mtx_unlock and braces

Harbormaster completed remote builds in B67297: Diff 162789.Sep 25 2025, 3:14 AM

markj added inline comments.Oct 4 2025, 12:48 PM

sys/netgraph/ng_device.c
534	We do not hold the ngd_mtx here, so this check is racy. Presumably we should check immediately before going to sleep below?
589
635	This is kind of misleading, as it reports only the number of bytes for the first packet in the queue, but we may have many packets available to read. The queue doesn't store the total number of bytes though, and probably we don't really want to traverse the whole queue to calculate the true number. I suggest adding a comment here explaining that.

Move ENXIO check behind mutex and add or fix comments

Harbormaster completed remote builds in B67982: Diff 164724.Oct 22 2025, 6:05 AM

quentin.thebault_defenso.fr marked 8 inline comments as done.Oct 22 2025, 6:09 AM

Looks ok to me.

This revision is now accepted and ready to land.Oct 22 2025, 12:44 PM

Thanks a lot for your help!

In D52541#1216658, @quentin.thebault_defenso.fr wrote:

Thanks a lot for your help!

Could you please mail me git format-patch-generated patches to apply to the tree? Or submit them as a pull request on github. Then I'll push them to main.

Here you go: https://github.com/freebsd/freebsd-src/pull/1880

Closed by commit rGa505b80b2f03: ng_device: add kqueue support (authored by quentin.thebault_defenso.fr, committed by markj). · Explain WhyOct 27 2025, 12:48 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa505b80b2f03: ng_device: add kqueue support.

markj added a commit: rGe1834bc89e64: ng_device: add kqueue support.Mon, Dec 1, 4:38 PM