udp: don't leak mbuf if tunnel didn't consume and inpcb is gone
ClosedPublic
Actions

Authored by glebius on Aug 26 2025, 5:09 PM.

Details

Reviewers

markj
kp
tuexen

Group Reviewers

transport

Commits

rGc8a5df48de6f: udp: don't leak mbuf if tunnel didn't consume and inpcb is gone

Summary

Fixes: e1751ef896119d7372035b1b60f18a6342bd0e3b

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66545
Build 63428: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 26 2025, 5:09 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 26 2025, 5:09 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Aug 26 2025, 5:09 PM

Harbormaster completed remote builds in B66545: Diff 161005.Aug 26 2025, 5:09 PM

glebius added a child revision: D52171: udp: slightly refactor udp_append().Aug 26 2025, 5:09 PM

Michael had fixed this bug at Netflix several years ago, but we forgot to upstream that. Merging in FreeBSD, I found our code also doesn't leak mbuf.

markj accepted this revision.Aug 26 2025, 5:27 PM

kp accepted this revision.Aug 26 2025, 6:11 PM

tuexen accepted this revision.Aug 26 2025, 6:45 PM

This revision is now accepted and ready to land.Aug 26 2025, 6:45 PM

Closed by commit rGc8a5df48de6f: udp: don't leak mbuf if tunnel didn't consume and inpcb is gone (authored by glebius). · Explain WhySep 1 2025, 4:34 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGc8a5df48de6f: udp: don't leak mbuf if tunnel didn't consume and inpcb is gone.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

udp_usrreq.c

5 lines

Diff 161005

View Options

udp: don't leak mbuf if tunnel didn't consume and inpcb is goneClosedPublicActions