libsamplerate: Build as internal library
AbandonedPublic
Actions

Authored by christos on Jul 31 2025, 5:48 PM.

Details

Reviewers

markj
emaste
fuz

Summary

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65879
Build 62762: arc lint + arc unit

Event Timeline

christos created this revision.Jul 31 2025, 5:48 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2025, 5:48 PM

christos requested review of this revision.Jul 31 2025, 5:48 PM

Harbormaster completed remote builds in B65867: Diff 159510.Jul 31 2025, 5:48 PM

Do we need to remove audio/libsamplerate from ports once this is committed?

I copied the tree from the virtual_oss codebase, but I forgot to remove some
#if 0s introduced by @fuz in
https://github.com/freebsd/virtual_oss/commit/6f05c06774956031b6ec115c0875ead3ebf4a1c9.
Remove them.

Harbormaster completed remote builds in B65868: Diff 159515.Jul 31 2025, 6:00 PM

This should be a private library if possible; I don't feel like we should add it to our documented API.
I would then also suggest to put the #if 0 back in.

In that case, the port should stay.

In D51657#1179993, @fuz wrote:

This should be a private library if possible; I don't feel like we should add it to our documented API.
I would then also suggest to put the #if 0 back in.

In that case, the port should stay.

I agree. A private library is effectively invisible to third-party software and is only intended for use by the base system. That way we don't have to worry about binary compatibility issues.

I believe it's sufficient to define PRIVATELIB= in the makefile.

lib/libsamplerate/Makefile
23	You'll also need to add this to the `_PRIVATELIBS` variable in share/mk/src.libnames.mk.

christos retitled this revision from libsamplerate: Vendor import to libsamplerate: Vendor import as internal library.Aug 1 2025, 10:03 AM

Address comments. Define as internal library.

Herald added a subscriber: bdrewery. · View Herald TranscriptAug 1 2025, 10:03 AM

Harbormaster completed remote builds in B65879: Diff 159533.Aug 1 2025, 10:03 AM

LGTM.

This revision is now accepted and ready to land.Aug 1 2025, 11:01 AM

Have you done a vendor import of the library? https://docs.freebsd.org/en/articles/committers-guide/#vendor-import-git

christos retitled this revision from libsamplerate: Vendor import as internal library to libsamplerate: Build as internal library.Aug 1 2025, 12:18 PM

christos edited the summary of this revision. (Show Details)

fuz mentioned this in D51665: Add 'contrib/libsamplerate/' from commit '69a539a327ef8d78260056c5394363569b5751ef'.Aug 1 2025, 12:19 PM

D51666

fuz mentioned this in D51666: libsamplerate: Build as internal library.Aug 1 2025, 12:23 PM