Page MenuHomeFreeBSD
Differential D55156

googletest: Link the gmock and gtest libraries against compiler_rt for aarch64
AcceptedPublic
Actions

Authored by jhb on Sat, Feb 7, 3:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 3, 2:23 AM
Unknown Object (File)
Sun, Mar 1, 8:22 AM
Unknown Object (File)
Sat, Feb 28, 8:17 AM
Unknown Object (File)
Fri, Feb 20, 2:41 PM
Unknown Object (File)
Tue, Feb 17, 12:27 PM
Unknown Object (File)
Tue, Feb 17, 4:37 AM
Unknown Object (File)
Fri, Feb 13, 6:27 AM
Unknown Object (File)
Thu, Feb 12, 1:07 PM
View All 9 Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
andrew
ngie
Summary

This is required for GCC which uses libcalls for outlined atomics.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70492
Build 67375: arc lint + arc unit

Event Timeline

jhb created this revision.Sat, Feb 7, 3:46 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptSat, Feb 7, 3:46 PM
jhb requested review of this revision.Sat, Feb 7, 3:46 PM
jhb added a parent revision: D55155: libmd aarch64: Use ands instead of bics to round down the length.
jhb added a child revision: D55157: llvm: Link private LLVM libraries against compiler_rt for aarch64.
Harbormaster completed remote builds in B70492: Diff 171410.Sat, Feb 7, 3:47 PM
jhb added reviewers: andrew, ngie.Sat, Feb 7, 3:47 PM
ngie accepted this revision.Sun, Feb 8, 7:44 AM
ngie added inline comments.
lib/googletest/gmock/Makefile
14

Does it make sense to add a compiler-check here? Just a general non-blocking question.

This revision is now accepted and ready to land.Sun, Feb 8, 7:44 AM
jhb added inline comments.Mon, Feb 9, 4:23 PM
lib/googletest/gmock/Makefile
14

It is hard because I don't think you can do the compiler check in src.libnames.mk.

ngie added inline comments.Thu, Feb 12, 9:42 PM
lib/googletest/gmock/Makefile
14

It looks like you can do it in src.libnames.mk, based on a quick code inspection of the file.

Revision Contents
Changeset List

PathSize
lib/
googletest/
gmock/
5 lines
gtest/
4 lines
share/
mk/
6 lines

Diff 171410

View Options

lib/googletest/gmock/Makefile

Loading...
View Options

lib/googletest/gtest/Makefile

Loading...
View Options

share/mk/src.libnames.mk

Loading...