Page MenuHomeFreeBSD

vchiq: Fix return type of vchiq_copy_from_user
ClosedPublic

Authored by jhb on Feb 7 2026, 3:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 8:47 AM
Unknown Object (File)
Fri, Apr 17, 5:07 PM
Unknown Object (File)
Thu, Apr 16, 3:07 PM
Unknown Object (File)
Wed, Apr 15, 8:14 AM
Unknown Object (File)
Sat, Apr 11, 1:07 AM
Unknown Object (File)
Tue, Apr 7, 7:41 AM
Unknown Object (File)
Tue, Apr 7, 4:58 AM
Unknown Object (File)
Sun, Apr 5, 7:19 PM
Subscribers

Details

Summary

Change the function definition to map the declaration and consistently
return an enum value. This fixes the following error reported by GCC:

sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c:322:1: error: conflicting types for 'vchiq_copy_from_user' due to enum/integer mismatch; have 'int(void *, const void *, int)' [-Werror=enum-int-mismatch]

322 | vchiq_copy_from_user(void *dst, const void *src, int size)
    | ^~~~~~~~~~~~~~~~~~~~

In file included from sys/contrib/vchiq/interface/vchiq_arm/vchiq_arm.h:38,

from sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c:61:

sys/contrib/vchiq/interface/vchiq_arm/vchiq_core.h:647:1: note: previous declaration of 'vchiq_copy_from_user' with type 'VCHIQ_STATUS_T(void *, const void *, int)'

647 | vchiq_copy_from_user(void *dst, const void *src, int size);
    | ^~~~~~~~~~~~~~~~~~~~

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2026, 8:48 PM
This revision was automatically updated to reflect the committed changes.