Differential D55159

sdhci_fdt_rockchip: Don't return 0 from probe routine
ClosedPublic
Actions

Authored by jhb on Sat, Feb 7, 3:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 2, 9:17 AM

	Unknown Object (File)
	Sat, Feb 28, 11:32 PM

	Unknown Object (File)
	Sat, Feb 28, 1:51 AM

	Unknown Object (File)
	Thu, Feb 26, 8:57 PM

	Unknown Object (File)
	Mon, Feb 23, 11:24 PM

	Unknown Object (File)
	Sun, Feb 22, 4:55 PM

	Unknown Object (File)
	Thu, Feb 19, 8:42 PM

	Unknown Object (File)
	Fri, Feb 13, 1:08 PM

View All 10 Files

Subscribers

Details

Reviewers

Commits

rG3f18463745c9: sdhci_fdt_rockchip: Don't return 0 from probe routine

Summary

The only write to the softc is a no-op (softcs are initialized to all
zeroes), so remove that and just use BUS_PROBE_DEFAULT.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sat, Feb 7, 3:46 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Feb 7, 3:46 PM

jhb requested review of this revision.Sat, Feb 7, 3:46 PM

jhb added a parent revision: D55158: sdhci_fdt_rockchip: Move ofw_bus_status_okay check.

jhb added a child revision: D55160: arm64: Explicitly use movz.

Harbormaster completed remote builds in B70495: Diff 171413.Sat, Feb 7, 3:47 PM

This is not required to build arm64 with GCC (the rest of this stack are fixes needed for that), but is just a cleanup I noticed while fixing the previous patch.

jhb added a reviewer: bnovkov.Sat, Feb 7, 3:48 PM

LGTM.

This revision is now accepted and ready to land.Sun, Feb 8, 4:39 PM

Closed by commit rG3f18463745c9: sdhci_fdt_rockchip: Don't return 0 from probe routine (authored by jhb). · Explain WhyMon, Feb 9, 4:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3f18463745c9: sdhci_fdt_rockchip: Don't return 0 from probe routine.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sdhci/

sdhci_fdt_rockchip.c

5 lines

Diff 171531

sys/dev/sdhci/sdhci_fdt_rockchip.c

Loading...