Page MenuHomeFreeBSD

bhyvectl/amd64: add --get-cpuid-cfg
AcceptedPublic

Authored by rosenfeld_grumpf.hope-2000.org on Jul 26 2025, 11:25 AM.
Tags
None
Referenced Files
F134926955: D51556.id164579.diff
Wed, Nov 5, 6:15 AM
F134881216: D51556.diff
Wed, Nov 5, 12:38 AM
F134744020: D51556.id159183.diff
Tue, Nov 4, 8:11 AM
Unknown Object (File)
Thu, Oct 30, 2:12 PM
Unknown Object (File)
Wed, Oct 29, 8:42 AM
Unknown Object (File)
Wed, Oct 29, 8:42 AM
Unknown Object (File)
Wed, Oct 29, 8:22 AM
Unknown Object (File)
Tue, Oct 28, 10:08 PM

Details

Reviewers
markj
Group Reviewers
bhyve
Summary

Add a command to bhyvectl to fetch and print the CPUID configuration
for a VCPU. The CPUID entries, if any, are printed in hex and ASCII. No
pretty-printing of the information is performed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65755
Build 62638: arc lint + arc unit

Event Timeline

markj added inline comments.
usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c
1927

Where exactly does it get filled in? This looks like it always queries vcpu 0, ignoring the --cpu parameter.

usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c
1927

This is done in vcpu_ioctl() in vmmapi.c, called by vm_get_cpuid() in vmmapi_machdep.c:

int
vcpu_ioctl(struct vcpu *vcpu, u_long cmd, void *arg)
{
	/*
	 * XXX: fragile, handle with care
	 * Assumes that the first field of the ioctl data
	 * is the vcpuid.
	 */
	*(int *)arg = vcpu->vcpuid;
	return (ioctl(vcpu->ctx->fd, cmd, arg));
}
markj added inline comments.
usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c
1927

Right, I forgot about that bit of magic. (I'd rather initialize vvcc_vcpuid = -1 in that case.)

This revision is now accepted and ready to land.Wed, Oct 22, 7:22 PM