tcp: unlock before syncookie_expand()
ClosedPublic
Actions

Authored by glebius on Tue, Jun 17, 4:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 3, 6:28 PM

	Unknown Object (File)
	Wed, Jul 2, 8:53 PM

	Unknown Object (File)
	Wed, Jul 2, 6:18 PM

	Unknown Object (File)
	Mon, Jun 30, 8:20 PM

	Unknown Object (File)
	Mon, Jun 30, 1:57 AM

	Unknown Object (File)
	Thu, Jun 26, 10:34 PM

	Unknown Object (File)
	Thu, Jun 26, 8:13 PM

	Unknown Object (File)
	Wed, Jun 25, 8:34 PM

View All 20 Files

Subscribers

imp

melifaro

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG0809d26de24d: tcp: unlock before syncookie_expand()

Summary

The function doesn't need a lock on sch. It uses the pointer as value for
the SipHash calculation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Tue, Jun 17, 4:16 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptTue, Jun 17, 4:16 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Tue, Jun 17, 4:16 AM

glebius added a parent revision: D50897: tcp: increase tcps_sc_recvcookie only in the syncache_expand().

Harbormaster completed remote builds in B64931: Diff 157160.Tue, Jun 17, 4:16 AM

glebius added a child revision: D50899: tcp: count two previously ignored kinds of syncookie failures.Tue, Jun 17, 4:16 AM

tuexen accepted this revision.Tue, Jun 17, 6:45 AM

This revision is now accepted and ready to land.Tue, Jun 17, 6:45 AM

Closed by commit rG0809d26de24d: tcp: unlock before syncookie_expand() (authored by glebius). · Explain WhyTue, Jun 17, 3:51 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG0809d26de24d: tcp: unlock before syncookie_expand().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

7 lines

Diff 157195

View Options

sys/netinet/tcp_syncache.c

tcp: unlock before syncookie_expand()ClosedPublicActions