Differential D50896

tcp: refactor debug function syncookie_cmp()
ClosedPublic
Actions

Authored by glebius on Jun 17 2025, 4:15 AM.

Tags

None

Referenced Files

	F167864255: D50896.id157158.diff
	Tue, Aug 25, 2:22 AM

	F167823592: D50896.id157193.diff
	Mon, Aug 24, 7:30 PM

	Unknown Object (File)
	Sun, Aug 23, 10:00 PM

	Unknown Object (File)
	Sun, Aug 23, 10:00 PM

	Unknown Object (File)
	Fri, Aug 14, 7:37 PM

	Unknown Object (File)
	Wed, Aug 12, 11:35 PM

	Unknown Object (File)
	Wed, Aug 12, 10:09 PM

	Unknown Object (File)
	Tue, Aug 11, 6:12 PM

View All 79 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rGf5d8084a8d5c: tcp: refactor debug function syncookie_cmp()
rGe9e6a025b452: tcp: refactor debug function syncookie_cmp()

Summary

Don't bzero() the test structure. All fields checked are set by syncache_expand().
Don't allocate TCP address logging string if there is nothing to report.
Mark hash bucket argument as pointer to const.
Make it void.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jun 17 2025, 4:15 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJun 17 2025, 4:15 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Jun 17 2025, 4:15 AM

Harbormaster completed remote builds in B64929: Diff 157158.Jun 17 2025, 4:16 AM

glebius added a parent revision: D50895: tcp: rename syncookie_lookup() into syncookie_expand() and make it bool.Jun 17 2025, 4:16 AM

glebius added a child revision: D50897: tcp: increase tcps_sc_recvcookie only in the syncache_expand().

This revision was not accepted when it landed; it landed in state Needs Review.Jun 17 2025, 3:51 PM

Closed by commit rGe9e6a025b452: tcp: refactor debug function syncookie_cmp() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGe9e6a025b452: tcp: refactor debug function syncookie_cmp().

tuexen added a commit: rGf5d8084a8d5c: tcp: refactor debug function syncookie_cmp().Sep 9 2025, 6:06 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

43 lines

Diff 157193

sys/netinet/tcp_syncache.c

Loading...