Differential D50897

tcp: increase tcps_sc_recvcookie only in the syncache_expand()
ClosedPublic
Actions

Authored by glebius on Tue, Jun 17, 4:16 AM.

Tags

None

Referenced Files

	F122629095: D50897.id157159.diff
	Sun, Jul 6, 10:02 PM

	F122520955: D50897.id157159.diff
	Sat, Jul 5, 11:18 PM

	Unknown Object (File)
	Tue, Jul 1, 6:30 PM

	Unknown Object (File)
	Mon, Jun 30, 6:26 PM

	Unknown Object (File)
	Mon, Jun 30, 7:08 AM

	Unknown Object (File)
	Sun, Jun 22, 11:56 PM

	Unknown Object (File)
	Sat, Jun 21, 3:30 AM

	Unknown Object (File)
	Thu, Jun 19, 3:21 AM

View All 13 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG3ed8d5645dd4: tcp: increase tcps_sc_recvcookie only in the syncache_expand()

Summary

The syncookie_expand() is called from syncookie_cmp() in INVARIANTS mode
to confirm that values calculated via syncookies mechanism match those
stored in the syncache entry. This creates a counting bug, that with
INVARIANTS every successful use of syncache also counts as use of a
syncookie.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Tue, Jun 17, 4:16 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptTue, Jun 17, 4:16 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Tue, Jun 17, 4:16 AM

Harbormaster completed remote builds in B64930: Diff 157159.Tue, Jun 17, 4:16 AM

glebius added a parent revision: D50896: tcp: refactor debug function syncookie_cmp().Tue, Jun 17, 4:16 AM

glebius added a child revision: D50898: tcp: unlock before syncookie_expand().

tuexen accepted this revision.Tue, Jun 17, 6:43 AM

This revision is now accepted and ready to land.Tue, Jun 17, 6:43 AM

Closed by commit rG3ed8d5645dd4: tcp: increase tcps_sc_recvcookie only in the syncache_expand() (authored by glebius). · Explain WhyTue, Jun 17, 3:51 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG3ed8d5645dd4: tcp: increase tcps_sc_recvcookie only in the syncache_expand().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

5 lines

Diff 157194

sys/netinet/tcp_syncache.c

Loading...