Differential D50897

tcp: increase tcps_sc_recvcookie only in the syncache_expand()
ClosedPublic
Actions

Authored by glebius on Jun 17 2025, 4:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 10, 12:26 AM

	Unknown Object (File)
	Sun, Nov 2, 7:43 PM

	Unknown Object (File)
	Sun, Oct 26, 1:24 PM

	Unknown Object (File)
	Sat, Oct 25, 1:35 AM

	Unknown Object (File)
	Fri, Oct 17, 7:25 PM

	Unknown Object (File)
	Fri, Oct 17, 5:25 AM

	Unknown Object (File)
	Sep 30 2025, 3:31 AM

	Unknown Object (File)
	Sep 14 2025, 12:11 AM

View All 31 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGea5560f2293b: tcp: increase tcps_sc_recvcookie only in the syncache_expand()
rG3ed8d5645dd4: tcp: increase tcps_sc_recvcookie only in the syncache_expand()

Summary

The syncookie_expand() is called from syncookie_cmp() in INVARIANTS mode
to confirm that values calculated via syncookies mechanism match those
stored in the syncache entry. This creates a counting bug, that with
INVARIANTS every successful use of syncache also counts as use of a
syncookie.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jun 17 2025, 4:16 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJun 17 2025, 4:16 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Jun 17 2025, 4:16 AM

Harbormaster completed remote builds in B64930: Diff 157159.Jun 17 2025, 4:16 AM

glebius added a parent revision: D50896: tcp: refactor debug function syncookie_cmp().Jun 17 2025, 4:16 AM

glebius added a child revision: D50898: tcp: unlock before syncookie_expand().

tuexen accepted this revision.Jun 17 2025, 6:43 AM

This revision is now accepted and ready to land.Jun 17 2025, 6:43 AM

Closed by commit rG3ed8d5645dd4: tcp: increase tcps_sc_recvcookie only in the syncache_expand() (authored by glebius). · Explain WhyJun 17 2025, 3:51 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG3ed8d5645dd4: tcp: increase tcps_sc_recvcookie only in the syncache_expand().

tuexen added a commit: rGea5560f2293b: tcp: increase tcps_sc_recvcookie only in the syncache_expand().Sep 9 2025, 6:06 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

5 lines

Diff 157194

sys/netinet/tcp_syncache.c

Loading...