Page MenuHomeFreeBSD
Differential D50687

lib{c,thr}: add kernel version guards on exterrctl
ClosedPublic
Actions

Authored by brooks on Jun 4 2025, 4:47 PM.
Tags
None
Referenced Files
F163352539: D50687.diff
Wed, Jul 22, 10:30 AM
Unknown Object (File)
Thu, Jul 16, 5:28 PM
Unknown Object (File)
Sun, Jul 12, 7:20 PM
Unknown Object (File)
Fri, Jul 10, 12:55 AM
Unknown Object (File)
Tue, Jul 7, 6:26 PM
Unknown Object (File)
Mon, Jul 6, 4:20 PM
Unknown Object (File)
Sun, Jul 5, 9:48 PM
Unknown Object (File)
Sat, Jul 4, 1:30 AM
View All 98 Files
Subscribers
imp

Details

Reviewers
kib
kevans
adrian
jhb
Commits
rGa5b0b2a7d421: C runtime: add kernel version guards on exterrctl
Summary

This allows userspace to run on a (somewhat) out of date kernel.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Jun 4 2025, 4:47 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 4 2025, 4:47 PM
brooks requested review of this revision.Jun 4 2025, 4:47 PM
Harbormaster completed remote builds in B64644: Diff 156541.Jun 4 2025, 4:47 PM
brooks added a parent revision: D50686: Bump __FreeBSD_version for exterrctl.Jun 4 2025, 4:47 PM
brooks added a comment.Jun 4 2025, 4:49 PM

Compile tested only. Not calling exterrctl should be equivalent to it returning ENOSYS when the kernel doesn't support it.

kevans accepted this revision.Jun 4 2025, 5:42 PM

Thanks!

This revision is now accepted and ready to land.Jun 4 2025, 5:42 PM
brooks added a comment.Jun 4 2025, 5:51 PM

I've now verified that a system with these patches applied, but the __FreeBSD_version bump rolled back boots fine and doesn't call exterrctl(). With the version bumped the calls are made.

brooks mentioned this in D50686: Bump __FreeBSD_version for exterrctl.Jun 4 2025, 6:04 PM
Closed by commit rGa5b0b2a7d421: C runtime: add kernel version guards on exterrctl (authored by brooks). · Explain WhyJun 4 2025, 6:09 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGa5b0b2a7d421: C runtime: add kernel version guards on exterrctl.

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
8 lines
libthr/
thread/
6 lines
5 lines
sys/
sys/
1 line

Diff 156543

View Options

lib/libc/gen/uexterr_gettext.c

Loading...
View Options

lib/libthr/thread/thr_create.c

Loading...
View Options

lib/libthr/thread/thr_init.c

Loading...
View Options

sys/sys/param.h

Loading...