route: fix rtentry double free
ClosedPublic
Actions

Authored by kp on Jun 3 2025, 12:49 PM.

Details

Reviewers

melifaro
ae

Group Reviewers

pfsense

Commits

rG38c655093c6b: route: fix rtentry double free

Summary

add_route_flags() frees the rtentry on error when called with the RTM_F_CREATE
flag. Don't free the rtentry a second time.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64614
Build 61498: arc lint + arc unit

Event Timeline

kp created this revision.Jun 3 2025, 12:49 PM

Herald added a reviewer: melifaro. · View Herald TranscriptJun 3 2025, 12:49 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

kp requested review of this revision.Jun 3 2025, 12:49 PM

Harbormaster completed remote builds in B64614: Diff 156471.Jun 3 2025, 12:49 PM

kp added a parent revision: D50664: UPDATING: document recent pf changes.Jun 3 2025, 12:49 PM

ae added inline comments.Jun 3 2025, 3:38 PM

sys/net/route/route_ctl.c
676	Then isn't this access to freed rt_new?

kp added inline comments.Jun 3 2025, 3:56 PM

sys/net/route/route_ctl.c
676	Good catch, I missed that one. I think we can get away with using 'rt' here instead of 'rt_new', because rt_new should be a copy of rt.

Remove one more use of rt_new

Harbormaster completed remote builds in B64618: Diff 156478.Jun 3 2025, 4:26 PM

ae accepted this revision.Jun 5 2025, 7:36 AM

This revision is now accepted and ready to land.Jun 5 2025, 7:36 AM

Closed by commit rG38c655093c6b: route: fix rtentry double free (authored by kp). · Explain WhyJun 5 2025, 9:33 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG38c655093c6b: route: fix rtentry double free.

Revision Contents
Changeset List

Path

Size

sys/

net/

route/

route_ctl.c

1 line

Diff 156471

View Options

route: fix rtentry double freeClosedPublicActions