share/mk: pass SHARED_CFLAGS to PIC and PIE from assembly
ClosedPublic
Actions

Authored by brooks on Thu, May 22, 3:02 PM.

Details

Reviewers

dg612_cam.ac.uk
jrtc27
jhb
dim
emaste

Commits

rG9c2001036185: share/mk: pass SHARED_CFLAGS to PIC and PIE from assembly

Summary

This mirrors what we do for C code.

PR: 286975

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64369
Build 61253: arc lint + arc unit

Event Timeline

brooks created this revision.Thu, May 22, 3:02 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptThu, May 22, 3:02 PM

brooks requested review of this revision.Thu, May 22, 3:02 PM

Harbormaster completed remote builds in B64355: Diff 155868.Thu, May 22, 3:03 PM

brooks added a parent revision: D50465: libsys: Use PICO_CFLAGS to disable syscall stubs.Thu, May 22, 3:03 PM

I wish we had these documented somewhere, so we could include a note that ${SHARED_CFLAGS} (along with ${CFLAGS} and ${PIEO_CFLAGS}/${PICO_CFLAGS} etc.).

I see three SHARED_CFLAGS references: in lib/libc/sys/Makefile.inc (noted in the PR), share/mk/bsd.sanitizer.mk, and lib/libarchive/Makefile.inc. I'm not sure why libarchive's addition of ICONV-related flags are in SHARED_CFLAGS not CFLAGS.