Differential D49546

athpoke: Use a format string with err()
ClosedPublic
Actions

Authored by adrian on Mar 27 2025, 11:44 PM.

Details

Reviewers

thj

Group Reviewers

wireless

Commits

rGd8482e1b3e14: athpoke: Use a format string with err()

Summary

Don't do err(1, ptr); that's a very old security risk turned warning.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63167
Build 60051: arc lint + arc unit

Event Timeline

adrian created this revision.Mar 27 2025, 11:44 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 27 2025, 11:44 PM

adrian requested review of this revision.Mar 27 2025, 11:44 PM

Harbormaster completed remote builds in B63167: Diff 152775.Mar 27 2025, 11:44 PM

adrian added a parent revision: D49545: ath: fix athtools common code to correctly init state.Mar 27 2025, 11:44 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

thj accepted this revision.Mar 28 2025, 3:38 PM

This revision is now accepted and ready to land.Mar 28 2025, 3:38 PM

Closed by commit rGd8482e1b3e14: athpoke: Use a format string with err() (authored by adrian). · Explain WhyMar 28 2025, 7:05 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGd8482e1b3e14: athpoke: Use a format string with err().

adrian added a child revision: D49575: net80211: validate control frame TA/RA before further processing.Mar 30 2025, 12:09 AM

Revision Contents
Changeset List

Path

Size

tools/

ath/

athpoke/

athpoke.c

6 lines

Diff 152775

View Options

tools/tools/ath/athpoke/athpoke.c

athpoke: Use a format string with err()ClosedPublicActions