committers guide: permit key words more than once
ClosedPublic
Actions

Authored by brooks on Thu, Mar 20, 9:55 PM.

Details

Reviewers

imp
emaste
kevans

Commits

R9:4ccefaf81a2e: committers guide: permit key words more than once

Summary

While some key words such as "MFC after:" should only appear once,
others such as "PR:" or "Sponsored by:" may be clearer if each entry
appears on it's own line. This is already somewhat common practice so
explicitly permit it.

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 63011
Build 59895: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Thu, Mar 20, 9:55 PM

brooks created this revision.

Harbormaster completed remote builds in B63010: Diff 152479.Thu, Mar 20, 9:55 PM

jbo added a subscriber: jbo.Thu, Mar 20, 9:57 PM

jbo added inline comments.

documentation/content/en/articles/committers-guide/_index.adoc
2545	Double "answers". Also, does "values" make more sense than "answers" here?

s/answers answers/values/ as pointed out by @jbo

Harbormaster completed remote builds in B63011: Diff 152480.Thu, Mar 20, 10:01 PM

zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Thu, Mar 20, 10:13 PM

Thanks!

This revision is now accepted and ready to land.Thu, Mar 20, 10:28 PM

This looks good. I think we may need to go from 'it is permitted' to 'It is preferred' at some point. Unlike the previous practice of comma separated lists, git trailers strongly prefer one per line. But I suspect we'll have to 'socialize' these changes more widely in the project, both to ports and src communities.

emaste accepted this revision.Fri, Mar 21, 1:45 AM

emaste added inline comments.