Page MenuHomeFreeBSD
Differential D49190

rtwn: add support for AES-GCM-128 in the supported software cipher set
ClosedPublic
Actions

Authored by adrian on Mar 1 2025, 4:38 AM.
Tags
Referenced Files
Unknown Object (File)
Mon, Aug 4, 1:06 AM
Unknown Object (File)
Sat, Aug 2, 6:57 PM
Unknown Object (File)
Sat, Aug 2, 4:19 AM
Unknown Object (File)
Fri, Jul 25, 8:16 AM
Unknown Object (File)
Mon, Jul 21, 7:55 AM
Unknown Object (File)
Mon, Jul 21, 5:05 AM
Unknown Object (File)
Mon, Jul 21, 5:01 AM
Unknown Object (File)
Mon, Jul 21, 4:37 AM
View All 49 Files
Subscribers
bz
emaste
imp

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG077108d94ae1: rtwn: add support for AES-GCM-128 in the supported software cipher set
Summary

I'm testing this with rtwn(4) NICs right now, so enable it here.

Locally tested:

  • RTL8812AU / RTL8821AU, STA mode (with some wpa_supplicant.conf shenanigans to force GCMP as the pairwise key to an OpenWRT AP configured to use GCMP but without requiring MFP.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62965
Build 59849: arc lint + arc unit

Event Timeline

adrian created this revision.Mar 1 2025, 4:38 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 1 2025, 4:38 AM
adrian requested review of this revision.Mar 1 2025, 4:38 AM
Harbormaster completed remote builds in B62707: Diff 151713.Mar 1 2025, 4:38 AM
adrian added a parent revision: D49189: net80211: add AES-GCM to the hostap logic.Mar 1 2025, 4:39 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D49196: ath: fix 20MHz HT short-gi logic..Mar 1 2025, 10:37 PM
bz requested changes to this revision.Mar 18 2025, 9:33 AM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/rtwn/if_rtwn.c
302

This should be ieee80211_set_software_ciphers() not the _crypto version.

This revision now requires changes to proceed.Mar 18 2025, 9:33 AM
adrian updated this revision to Diff 152402.Mar 18 2025, 11:40 PM

update from bz

Harbormaster completed remote builds in B62965: Diff 152402.Mar 18 2025, 11:40 PM
bz accepted this revision.Mar 19 2025, 12:34 PM
This revision is now accepted and ready to land.Mar 19 2025, 12:34 PM
emaste added a subscriber: emaste.Mar 19 2025, 2:01 PM
adrian marked an inline comment as done.Mar 20 2025, 4:30 AM
Closed by commit rG077108d94ae1: rtwn: add support for AES-GCM-128 in the supported software cipher set (authored by adrian). · Explain WhyMar 27 2025, 1:29 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG077108d94ae1: rtwn: add support for AES-GCM-128 in the supported software cipher set.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
5 lines

Diff 152402

View Options

sys/dev/rtwn/if_rtwn.c

Loading...