Page MenuHomeFreeBSD
Differential D48610

net80211: add ieee80211_vht_node_check_valid_mcs()
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:39 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Apr 16, 11:04 AM
Unknown Object (File)
Fri, Mar 28, 12:35 AM
Unknown Object (File)
Mar 9 2025, 1:07 PM
Unknown Object (File)
Mar 7 2025, 2:48 PM
Unknown Object (File)
Mar 7 2025, 2:37 PM
Unknown Object (File)
Mar 7 2025, 9:57 AM
Unknown Object (File)
Mar 7 2025, 7:43 AM
Unknown Object (File)
Mar 7 2025, 7:30 AM
View All 40 Files
Subscribers
bz
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG7b0e3c5b2b74: net80211: add ieee80211_vht_node_check_tx_valid_mcs()
Summary

Introduce ieee80211_vht_node_check_valid_mcs(), which takes the
node, bandwidth, NSS and MCS and validates whether that is possible
to the given node.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62132
Build 59016: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:39 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:39 AM
adrian requested review of this revision.Jan 23 2025, 2:39 AM
Harbormaster completed remote builds in B61901: Diff 149739.Jan 23 2025, 2:39 AM
adrian added a child revision: D48609: net80211: add node VHT transmit rate helper functions.Jan 23 2025, 2:39 AM
adrian removed a child revision: D48609: net80211: add node VHT transmit rate helper functions.
adrian added a parent revision: D48609: net80211: add node VHT transmit rate helper functions.
adrian added a child revision: D48248: net80211: refactor amrr_update() into HT and legacy paths.
adrian added a reviewer: wireless.Jan 23 2025, 3:05 AM
adrian added a project: wireless.
adrian updated this revision to Diff 149850.Jan 24 2025, 1:52 AM

rebase

Harbormaster completed remote builds in B61961: Diff 149850.Jan 24 2025, 1:52 AM
adrian updated this revision to Diff 149902.Jan 24 2025, 3:31 PM

rebase

Harbormaster completed remote builds in B61988: Diff 149902.Jan 24 2025, 3:31 PM
adrian updated this revision to Diff 150006.Jan 27 2025, 12:16 AM

rebase, address changes

Harbormaster completed remote builds in B62054: Diff 150006.Jan 27 2025, 12:16 AM
adrian updated this revision to Diff 150152.Jan 30 2025, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62117: Diff 150152.Jan 30 2025, 5:15 AM
adrian updated this revision to Diff 150167.Jan 30 2025, 5:16 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62132: Diff 150167.Jan 30 2025, 5:16 AM
bz requested changes to this revision.Feb 16 2025, 7:34 PM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211_vht.c
1079

Forgive me; I don't like the name (and description). You are checking if it's valid for TX?

This revision now requires changes to proceed.Feb 16 2025, 7:34 PM
adrian updated this revision to Diff 151105.Feb 17 2025, 4:40 AM

comment from bz@

Harbormaster completed remote builds in B62482: Diff 151105.Feb 17 2025, 4:40 AM
adrian marked an inline comment as done.Feb 17 2025, 4:41 AM
bz accepted this revision.Feb 17 2025, 2:43 PM

The description could also have enjoyed a update but fine.

This revision is now accepted and ready to land.Feb 17 2025, 2:43 PM
adrian added a comment.Feb 17 2025, 3:16 PM

i'll (try to remember to!) update it when I land it. I've updated the body of the commit message in the diff, but not the summary (yet).

I don't wanna break the git arc workflow that depends on the summary line not changing!

Closed by commit rG7b0e3c5b2b74: net80211: add ieee80211_vht_node_check_tx_valid_mcs() (authored by adrian). · Explain WhyFeb 26 2025, 7:32 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG7b0e3c5b2b74: net80211: add ieee80211_vht_node_check_tx_valid_mcs().

Revision Contents
Changeset List

PathSize
sys/
net80211/
2 lines
49 lines

Diff 150167

View Options

sys/net80211/ieee80211_vht.h

Show All 20 Lines
.if ${MK_ZFS} != "no" .if ${MK_ZFS} != "no"
_libzfs_core= libzfs_core _libzfs_core= libzfs_core
_libzfs= libzfs _libzfs= libzfs
.if ${MK_LIBTHR} != "no" .if ${MK_LIBTHR} != "no"
_libzpool= libzpool _libzpool= libzpool
.endif .endif
.endif .endif
.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" || \ .if ${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_ARCH} == "amd64" || \
${MACHINE_CPUARCH} == "mips" || ${MACHINE_CPUARCH} == "powerpc" || \ ${MACHINE_CPUARCH} == "arm" || ${MACHINE_ARCH} == "i386" || \
${MACHINE_CPUARCH} == "arm" ${MACHINE_CPUARCH} == "mips" || ${MACHINE_CPUARCH} == "powerpc"
andrewUnsubmitted
Done
Inline Actions

This should be sorted, it was missed when arm was added, but that shouldn't mean we do the same with AArch64.

andrew: This should be sorted, it was missed when arm was added, but that shouldn't mean we do the same…
_drti= drti _drti= drti
_libdtrace= libdtrace _libdtrace= libdtrace
.endif .endif
SUBDIR_DEPEND_libdtrace= libctf SUBDIR_DEPEND_libdtrace= libctf
SUBDIR_DEPEND_libzfs_core= libnvpair SUBDIR_DEPEND_libzfs_core= libnvpair
SUBDIR_DEPEND_libzfs= libavl libnvpair libumem libuutil libzfs_core SUBDIR_DEPEND_libzfs= libavl libnvpair libumem libuutil libzfs_core
SUBDIR_DEPEND_libzpool= libavl libnvpair libumem SUBDIR_DEPEND_libzpool= libavl libnvpair libumem
SUBDIR_PARALLEL= SUBDIR_PARALLEL=
.include <bsd.subdir.mk> .include <bsd.subdir.mk>
View Options

sys/net80211/ieee80211_vht.c

Show All 20 Lines
.if ${MK_ZFS} != "no" .if ${MK_ZFS} != "no"
_libzfs_core= libzfs_core _libzfs_core= libzfs_core
_libzfs= libzfs _libzfs= libzfs
.if ${MK_LIBTHR} != "no" .if ${MK_LIBTHR} != "no"
_libzpool= libzpool _libzpool= libzpool
.endif .endif
.endif .endif
.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" || \ .if ${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_ARCH} == "amd64" || \
${MACHINE_CPUARCH} == "mips" || ${MACHINE_CPUARCH} == "powerpc" || \ ${MACHINE_CPUARCH} == "arm" || ${MACHINE_ARCH} == "i386" || \
${MACHINE_CPUARCH} == "arm" ${MACHINE_CPUARCH} == "mips" || ${MACHINE_CPUARCH} == "powerpc"
andrewUnsubmitted
Done
Inline Actions

This should be sorted, it was missed when arm was added, but that shouldn't mean we do the same with AArch64.

andrew: This should be sorted, it was missed when arm was added, but that shouldn't mean we do the same…
_drti= drti _drti= drti
_libdtrace= libdtrace _libdtrace= libdtrace
.endif .endif
SUBDIR_DEPEND_libdtrace= libctf SUBDIR_DEPEND_libdtrace= libctf
SUBDIR_DEPEND_libzfs_core= libnvpair SUBDIR_DEPEND_libzfs_core= libnvpair
SUBDIR_DEPEND_libzfs= libavl libnvpair libumem libuutil libzfs_core SUBDIR_DEPEND_libzfs= libavl libnvpair libumem libuutil libzfs_core
SUBDIR_DEPEND_libzpool= libavl libnvpair libumem SUBDIR_DEPEND_libzpool= libavl libnvpair libumem
SUBDIR_PARALLEL= SUBDIR_PARALLEL=
.include <bsd.subdir.mk> .include <bsd.subdir.mk>