sys/dev/ath/ath_rate/onoe/onoe.c
206	uint8_t
394	This is sorted but nor marked as done?
sys/dev/ipw/if_ipw.c
841	Funny that iwi right below holds the reference over this but ipw did not...
sys/dev/mwl/if_mwl.c
3347	Can this be an uint8_t or does it have to stay int? ( I haven't checked the surrounding code )
sys/dev/wtap/if_wtap.c
620	Is there a leading blank here?

This revision now requires changes to proceed.Jan 26 2025, 10:23 PM

rebase, address changes

Harbormaster completed remote builds in B62046: Diff 149998.Jan 27 2025, 12:15 AM

adrian added inline comments.Jan 29 2025, 4:26 AM

sys/dev/ath/ath_rate/onoe/onoe.c
394	it's really kbit now, not 1/2mbit
sys/dev/ipw/if_ipw.c
841	Yeah this wasn't ever consistent. A lot (and I mean a /lot/) of hilarity in crashes in the past due to the node refcounting/garbage collecting locking changes same did years ago. It would be great to also clean this stuff up and make it consistent.
sys/dev/mwl/if_mwl.c
3347	I think it's a HW field first, not a dot11rate

gavin added a subscriber: gavin.Jan 29 2025, 9:25 PM

gavin added inline comments.

sys/dev/ath/ath_rate/onoe/onoe.c
225–227	Extra trailing brace?

update, fix things from gavin/bz

Harbormaster completed remote builds in B62104: Diff 150138.Jan 30 2025, 12:45 AM

fixed, please re-review!

sys/dev/wtap/if_wtap.c
620	nope, just a tab!

update, add TXRATE_HT

Harbormaster completed remote builds in B62109: Diff 150144.Jan 30 2025, 5:14 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62124: Diff 150159.Jan 30 2025, 5:15 AM

add mtw, now that it landed in -head

Harbormaster completed remote builds in B62336: Diff 150788.Mon, Feb 10, 8:13 PM

I think that dot11rate should be a uint8_t, but you can change it on commit if you agree

sys/dev/ath/ath_rate/amrr/amrr.c
248–252

bz requested changes to this revision.Sat, Feb 15, 12:13 PM

bz added inline comments.

sys/dev/ath/ath_rate/amrr/amrr.c
248–252	@adrian this still needs to be addressed?
sys/dev/ath/ath_rate/sample/sample.c
860	Is this actually correct still or does it need to be (pseudo-code)? if (HT) ieee80211_node_set_txrate_ht_mcsrate else ieee80211_node_set_txrate_dot11rate
sys/dev/iwm/if_iwm.c
3454	This could move down to line 3467 (next to tx_resp_rate).
sys/dev/usb/wlan/if_mtw.c
2165 ↗	(On Diff #150788)	This is probably wrong and should go under 2212 once rate control is done?

This revision now requires changes to proceed.Sat, Feb 15, 12:13 PM

@adrian did you miss this one? It has some question from thj and me open now. If this gets sorted then the first four of your stack are in :) I'll do the next ones now.

In D48602#1117904, @bz wrote:

@adrian did you miss this one? It has some question from thj and me open now. If this gets sorted then the first four of your stack are in :) I'll do the next ones now.

I'm still getting to em :)

address some more comments from thj/bz

sys/dev/ath/ath_rate/sample/sample.c
860	fwiw, dot11rate still works fine for HT and legacy.

adrian marked 4 inline comments as done.Sun, Feb 16, 8:48 PM

Harbormaster completed remote builds in B62480: Diff 151103.Sun, Feb 16, 8:49 PM

bz accepted this revision as: bz.Sun, Feb 16, 8:53 PM

bz accepted this revision.

This revision is now accepted and ready to land.Sun, Feb 16, 8:53 PM

There is a way to close this with the commit https://cgit.FreeBSD.org/src/commit/?id=7067450010931479f8dd97e51e4c5bf6a4d34c7e but I never know how; @emaste what is the magic if Phab did not do it automatically from the commit hooks?

adrian closed this revision.Thu, Feb 27, 12:16 AM

adrian added a commit: rG706745001093: sys: convert ni->ni_txrate references use to the new net80211 API.

Adrian got it: if it's accepted it can be closed, then Edit Related Objects -> Edit Commits.

sys: convert ni->ni_txrate references use to the new net80211 API
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 150138

sys/compat/linuxkpi/common/src/linux_80211.c

sys/dev/ath/ath_rate/amrr/amrr.c

sys/dev/ath/ath_rate/onoe/onoe.c

sys/dev/ath/ath_rate/sample/sample.c

sys/dev/bwi/if_bwi.c

sys/dev/bwn/if_bwn.c

sys/dev/ipw/if_ipw.c

sys/dev/iwi/if_iwi.c

sys/dev/iwm/if_iwm.c

sys/dev/iwn/if_iwn.c

sys/dev/malo/if_malo.c

sys/dev/mwl/if_mwl.c

sys/dev/otus/if_otus.c

sys/dev/ral/rt2560.c

sys/dev/ral/rt2661.c

sys/dev/ral/rt2860.c

sys/dev/rtwn/if_rtwn_tx.c

sys/dev/usb/wlan/if_rsu.c

sys/dev/usb/wlan/if_rum.c

sys/dev/usb/wlan/if_run.c

sys/dev/usb/wlan/if_uath.c

sys/dev/usb/wlan/if_ural.c

sys/dev/usb/wlan/if_zyd.c

sys/dev/wpi/if_wpi.c

sys/dev/wtap/if_wtap.c

sys: convert ni->ni_txrate references use to the new net80211 APIClosedPublicActions