Differential D48609

net80211: add node VHT transmit rate helper functions
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:38 AM.

Tags

Referenced Files

	F111895268: D48609.id149901.diff
	Sun, Mar 9, 10:47 PM

	Unknown Object (File)
	Sat, Mar 1, 3:55 PM

	Unknown Object (File)
	Thu, Feb 27, 12:16 AM

	Unknown Object (File)
	Sun, Feb 23, 7:42 PM

	Unknown Object (File)
	Fri, Feb 21, 8:20 PM

	Unknown Object (File)
	Fri, Feb 21, 1:22 PM

	Unknown Object (File)
	Thu, Feb 13, 11:12 PM

	Unknown Object (File)
	Wed, Feb 12, 4:12 AM

View All 32 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG1086f7bab303: net80211: add node VHT transmit rate helper functions

Summary

add a node VHT transmit function, which configures the parameters accordingly.

add a node VHT transmit function which just copies in another ieee80211_node_txrate struct.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61987
Build 58871: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:38 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:38 AM

adrian requested review of this revision.Jan 23 2025, 2:38 AM

Harbormaster completed remote builds in B61900: Diff 149738.Jan 23 2025, 2:39 AM

adrian added a parent revision: D48608: net80211: add valid VHT MCS combinations and helper functions.Jan 23 2025, 2:39 AM

adrian added a parent revision: D48610: net80211: add ieee80211_vht_node_check_valid_mcs().

adrian removed a parent revision: D48610: net80211: add ieee80211_vht_node_check_valid_mcs().

adrian added a child revision: D48610: net80211: add ieee80211_vht_node_check_valid_mcs().

adrian added a reviewer: wireless.Jan 23 2025, 3:05 AM

adrian added a project: wireless.

rebase

Harbormaster completed remote builds in B61960: Diff 149849.Jan 24 2025, 1:52 AM

rebase

Harbormaster completed remote builds in B61987: Diff 149901.Jan 24 2025, 3:31 PM

rebase, address changes

Harbormaster completed remote builds in B62053: Diff 150005.Jan 27 2025, 12:16 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62116: Diff 150151.Jan 30 2025, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62131: Diff 150166.Jan 30 2025, 5:16 AM

add MPASS()

Harbormaster completed remote builds in B62450: Diff 151044.Fri, Feb 14, 4:45 PM

Apart from the consistency I am fine with this too.

sys/net80211/ieee80211_node.c
3256	I am confused by argument order here. Even below they are assigned in different order. Can we for consistency always have one first and the other second and not one this one that? It'll save accidents.

bz accepted this revision as: bz.Sun, Feb 16, 8:54 PM

bz added inline comments.

sys/net80211/ieee80211_node.c
3256	Turns out it's left/first or right/second depending on where to look. So maybe ignore this. Case might be lost.

This revision is now accepted and ready to land.Sun, Feb 16, 8:54 PM

Closed by commit rG1086f7bab303: net80211: add node VHT transmit rate helper functions (authored by adrian). · Explain WhyWed, Feb 26, 7:32 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG1086f7bab303: net80211: add node VHT transmit rate helper functions.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_node.h

4 lines

ieee80211_node.c

37 lines

Diff 149901

sys/net80211/ieee80211_node.h

Loading...

sys/net80211/ieee80211_node.c

Loading...