Update ieee80211_node_get_txrate_mbit() to use
ieee80211_phy_vht_get_mcs_kbit() to calculate VHT rates.
For now just assume long-GI; I'd have to go and do some extra
work to figure out which short/long GI flag to use.
Details
Details
- Reviewers
thj bz - Group Reviewers
wireless - Commits
- rG6fef9e7378d0: net80211: update ieee80211_node_get_txrate_mbit() to support VHT
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 61966 Build 58850: arc lint + arc unit
Event Timeline
Comment Actions
The commit message already talks about the wrong function (kbit ot mbit).
| sys/net80211/ieee80211_node.c | ||
|---|---|---|
| 3300 | Why not just add the checks for 80/160 and pass the bool accordingly rather than leaving a comment no one will find again the next 10 years? We don't have a ni_flag for it but it's in the iv/ni_vhtcap and probably not duplicating the information but having an accessor function would be a lot better and less confusing anyway. | |
| sys/net80211/ieee80211_node.c | ||
|---|---|---|
| 3300 | heh. fine. :-) I'm happy to take on a task to clean this up once the diff stack lands. I don't wanna try and insert some more commits into this already big diff stack. I'll take a TODO to write an analogue to the HT shortgi methods, and also write a HT one that takes a bandwidth as well to clean that API up. | |