Differential D48615

net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:45 AM.

Tags

Referenced Files

	F136291276: D48615.id149909.diff
	Mon, Nov 17, 1:40 AM

	F136197670: D48615.diff
	Sun, Nov 16, 3:11 PM

	Unknown Object (File)
	Sat, Nov 15, 8:27 PM

	Unknown Object (File)
	Fri, Nov 14, 8:48 PM

	Unknown Object (File)
	Fri, Nov 14, 3:35 PM

	Unknown Object (File)
	Fri, Nov 14, 12:27 PM

	Unknown Object (File)
	Thu, Nov 13, 2:30 PM

	Unknown Object (File)
	Tue, Nov 4, 2:48 PM

Subscribers

Details

Reviewers

thj
bz

Group Reviewers

Commits

rGe274a23c0d3d: net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate

Summary

This is one of the two obvious left-over dot11rate lookups that trigger
a debug print. (The other is get_sta_info()).

Change ieee80211_rate2media() to use the passed in ieee80211_node_txrate and use the rate type field to see if it's legacy/ht or vht.
.. and (I hope!) actually handle the VHT rate correctly.
Change the callers of ieee80211_rate2media() to use the new static initialisers.

For the one spot in ieee80211_ht.c which uses the HT initialiser, it should
just be a straight up mechanical change that correctly sets the HT MCS
rate.

For the rest of them in ieee80211.c, they're doing table initialisation
for the media types / rates, and it's currently very focused on legacy
rates. So just leave that all as-is for now with a mechanical change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61908
Build 58792: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:45 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:45 AM

adrian requested review of this revision.Jan 23 2025, 2:45 AM

Harbormaster completed remote builds in B61908: Diff 149746.Jan 23 2025, 2:45 AM

adrian added a parent revision: D48614: net80211: add static initialisers for the ieee80211_node_txrate options.Jan 23 2025, 2:45 AM

adrian added a child revision: D48616: net80211: update get_sta_info() to only populate isi_txrate for legacy rates.

adrian added a reviewer: wireless.Jan 23 2025, 3:07 AM

adrian added a project: wireless.

rebase

Harbormaster completed remote builds in B61968: Diff 149857.Jan 24 2025, 1:53 AM

rebase

Harbormaster completed remote builds in B61995: Diff 149909.Jan 24 2025, 3:32 PM

rebase, address changes

Harbormaster completed remote builds in B62061: Diff 150013.Jan 27 2025, 12:16 AM

thj accepted this revision.Jan 28 2025, 10:09 AM

thj added a subscriber: thj.

thj added inline comments.

sys/net80211/ieee80211.c
2736	Don't add the extra newline when this lands

This revision is now accepted and ready to land.Jan 28 2025, 10:09 AM

update, add TXRATE_HT

This revision now requires review to proceed.Jan 30 2025, 5:16 AM

Harbormaster completed remote builds in B62139: Diff 150174.Jan 30 2025, 5:16 AM

adrian marked an inline comment as done.Feb 19 2025, 2:33 AM

bz requested changes to this revision.Feb 22 2025, 11:22 AM

bz added a subscriber: bz.

bz added inline comments.

sys/net80211/ieee80211.c
2540	int m, rate;
2578	Variable declaration above.

This revision now requires changes to proceed.Feb 22 2025, 11:22 AM

updates from bz

Harbormaster completed remote builds in B62631: Diff 151491.Feb 26 2025, 5:15 AM

updated, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 7:32 PM

Closed by commit rGe274a23c0d3d: net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGe274a23c0d3d: net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

56 lines

5 lines

ieee80211_var.h

3 lines

Diff 149746

sys/net80211/ieee80211.c

Loading...

sys/net80211/ieee80211_ht.c

Loading...

sys/net80211/ieee80211_var.h

Loading...