Differential D48429

amrr: refactor amrr_node_init() into HT and legacy paths
ClosedPublic
Actions

Authored by adrian on Jan 11 2025, 3:05 PM.

Tags

Referenced Files

	F135919788: D48429.id149741.diff
	Fri, Nov 14, 4:09 AM

	F135905147: D48429.id149741.diff
	Fri, Nov 14, 12:48 AM

	F135891566: D48429.id150169.diff
	Thu, Nov 13, 10:11 PM

	Unknown Object (File)
	Thu, Nov 13, 9:10 PM

	Unknown Object (File)
	Thu, Nov 13, 5:39 PM

	Unknown Object (File)
	Thu, Nov 13, 12:22 PM

	Unknown Object (File)
	Wed, Nov 12, 6:48 AM

	Unknown Object (File)
	Sun, Nov 9, 5:33 AM

Subscribers

Details

Reviewers

thj
bz

Group Reviewers

Commits

rG078acac88264: net80211: refactor amrr_node_init() into HT and legacy paths

Summary

Refactor amrr_node_init() into HT and legacy paths, clean up the
printing to be a bit clearer about the selected rates.

This is precursor work to setting VHT rates in ni->ni_txrate .

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61903
Build 58787: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 11 2025, 3:05 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 11 2025, 3:05 PM

adrian requested review of this revision.Jan 11 2025, 3:05 PM

Harbormaster completed remote builds in B61674: Diff 149134.Jan 11 2025, 3:06 PM

adrian added a reviewer: wireless.Jan 11 2025, 3:07 PM

adrian added a project: wireless.

adrian added a parent revision: D48248: net80211: refactor amrr_update() into HT and legacy paths.

adrian added a child revision: D48428: rtwn: fix RTL8192EU power-down / power-up hanging.

rebase

Harbormaster completed remote builds in B61903: Diff 149741.Jan 23 2025, 2:41 AM

adrian removed a child revision: D48428: rtwn: fix RTL8192EU power-down / power-up hanging.Jan 23 2025, 2:42 AM

adrian added a child revision: D48611: net80211: add VHT MCS in AMRR rate control.

rebase

Harbormaster completed remote builds in B61963: Diff 149852.Jan 24 2025, 1:52 AM

rebase

Harbormaster completed remote builds in B61990: Diff 149904.Jan 24 2025, 3:32 PM

rebase, address changes

Harbormaster completed remote builds in B62056: Diff 150008.Jan 27 2025, 12:16 AM

thj accepted this revision.Jan 28 2025, 10:10 AM

This revision is now accepted and ready to land.Jan 28 2025, 10:10 AM

update, add TXRATE_HT

This revision now requires review to proceed.Jan 30 2025, 5:15 AM

Harbormaster completed remote builds in B62119: Diff 150154.Jan 30 2025, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62134: Diff 150169.Jan 30 2025, 5:16 AM

bz requested changes to this revision.Feb 22 2025, 10:19 AM

bz added a subscriber: bz.

bz added inline comments.

sys/net80211/ieee80211_amrr.c
149	Ok, this won't fly. rs is NULL. The line below initializes rs. This code was never run.
183	And again here. rs is NULL. This is a NULL pointer deref.

This revision now requires changes to proceed.Feb 22 2025, 10:19 AM

from bz; address NULL pointer deref (which I've not hit, and now I'm curious why!)

Harbormaster completed remote builds in B62582: Diff 151346.Feb 22 2025, 5:07 PM

hi, try that! I don't know why I wasn't hitting this; i've definitely tested 2g 11n/11g and 5g 11n!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 7:32 PM

Closed by commit rG078acac88264: net80211: refactor amrr_node_init() into HT and legacy paths (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG078acac88264: net80211: refactor amrr_node_init() into HT and legacy paths.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_amrr.c

123 lines

Diff 149741

sys/net80211/ieee80211_amrr.c

Loading...