Page MenuHomeFreeBSD

MAC/do: Remove PR_METHOD_REMOVE method
ClosedPublic

Authored by olce on Nov 15 2024, 5:06 PM.
Tags
None
Referenced Files
F131541361: D47599.diff
Thu, Oct 9, 2:27 AM
Unknown Object (File)
Mon, Sep 29, 9:11 PM
Unknown Object (File)
Wed, Sep 24, 3:31 AM
Unknown Object (File)
Wed, Sep 24, 3:30 AM
Unknown Object (File)
Tue, Sep 16, 5:31 PM
Unknown Object (File)
Tue, Sep 16, 5:28 PM
Unknown Object (File)
Wed, Sep 10, 4:22 AM
Unknown Object (File)
Tue, Sep 9, 7:33 PM

Details

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
It isn't really needed, since common jail code destroys jail OSD storage
at jail destruction (via osd_jail_exit()), triggering our destructor
dealloc_osd(). Leveraging this mechanism is arguably even better as it
causes deallocation to always happen without the 'allprison_lock' lock.

While here, make the static definition of 'methods' top-level, renaming
it to 'osd_methods'.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60590
Build 57474: arc lint + arc unit

Event Timeline

olce requested review of this revision.Nov 15 2024, 5:06 PM
This revision is now accepted and ready to land.Nov 19 2024, 7:59 AM
sys/security/mac_do/mac_do.c
448

Should the const qualifier be dropped?

sys/security/mac_do/mac_do.c
448

What for? Jail methods are not supposed to be dynamically changed.

I may have guessed why you're asking this, and if so the answer is here: D46886.

sys/security/mac_do/mac_do.c
448

Ah yes, Nice!

olce marked 2 inline comments as done.Nov 26 2024, 2:22 PM
This revision was automatically updated to reflect the committed changes.