Page MenuHomeFreeBSD
Differential D47591

MAC/do: parse_rules(): Copy input string on its own
ClosedPublic
Actions

Authored by olce on Nov 15 2024, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 7, 12:07 AM
Unknown Object (File)
Sat, Apr 4, 9:29 AM
Unknown Object (File)
Thu, Apr 2, 6:27 AM
Unknown Object (File)
Wed, Apr 1, 4:37 AM
Unknown Object (File)
Fri, Mar 27, 11:41 PM
Unknown Object (File)
Mar 7 2026, 2:29 PM
Unknown Object (File)
Feb 28 2026, 7:28 PM
Unknown Object (File)
Feb 23 2026, 10:21 AM
View All 91 Files
Subscribers
emaste
imp
jlduran
lwhsu

Details

Reviewers
bapt
Commits
rGd84014ce3aae: MAC/do: parse_rules(): Copy input string on its own
rG2200a3ec711b: MAC/do: parse_rules(): Copy input string on its own
Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
Since all callers have to do it, save them that burden and do it in
parse_rules() instead.

While here, replace "strlen(x) == 0" with the simpler and more efficient
"x[0] == '\0'".

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60582
Build 57466: arc lint + arc unit

Event Timeline

olce created this revision.Nov 15 2024, 5:06 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 15 2024, 5:06 PM
olce requested review of this revision.Nov 15 2024, 5:06 PM
Harbormaster completed remote builds in B60582: Diff 146524.Nov 15 2024, 5:06 PM
olce mentioned this in D47633: MAC/do 2.0.Nov 15 2024, 10:43 PM
olce edited the summary of this revision. (Show Details)
olce added a child revision: D47592: MAC/do: Rename rule_is_valid() => rule_applies().Nov 15 2024, 10:47 PM
olce added a reviewer: bapt.Nov 15 2024, 10:49 PM
olce added subscribers: lwhsu, emaste.Nov 15 2024, 10:51 PM
olce added a subscriber: jlduran.Nov 18 2024, 8:50 AM
lwhsu added a comment.Nov 18 2024, 7:52 PM

In the proposed commit message, I guess you mean:

While here, replace strlen(x) == 0 with the simpler and more efficient
x[0] == '\0'.

Note 0 and \0. I believe the later is better.

olce added a comment.Nov 18 2024, 8:01 PM
In D47591#1086749, @lwhsu wrote:

Note 0 and \0. I believe the later is better.

Yes. The initial version probably was using 0 and later I changed the code but forgetting to update the commit message. Will do.

bapt accepted this revision.Nov 19 2024, 7:47 AM
This revision is now accepted and ready to land.Nov 19 2024, 7:47 AM
olce edited the summary of this revision. (Show Details)Nov 26 2024, 2:12 PM
olce added a parent revision: D47771: MAC/do: Sort header inclusions.Nov 26 2024, 8:13 PM
Closed by commit rG2200a3ec711b: MAC/do: parse_rules(): Copy input string on its own (authored by olce). · Explain WhyDec 16 2024, 2:46 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG2200a3ec711b: MAC/do: parse_rules(): Copy input string on its own.
olce added a commit: rGd84014ce3aae: MAC/do: parse_rules(): Copy input string on its own.Apr 3 2025, 7:33 PM

Revision Contents
Changeset List

PathSize
sys/
security/
mac_do/
27 lines

Diff 146524

View Options

sys/security/mac_do/mac_do.c

Loading...