release: set compat.linuxkpi.skb.mem_limit=1 in loader.conf
AbandonedPublic
Actions

Authored by bz on Nov 3 2024, 12:19 AM.

Details

Reviewers

emaste

Group Reviewers

releng

Summary

For the time being rtw88(4) and rtw89(4) need to limit memory to the
lower 4G (see their man pages) in order to work properly.
Set the sysctl on the release media.
I believe the proper way to handle this in the future (with more time)
would be to have the firmware port to install a file into
/boot/loader.conf.d/ but this would unlikely make it for 14.2-R in time.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60353
Build 57237: arc lint + arc unit

Event Timeline

bz created this revision.Nov 3 2024, 12:19 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptNov 3 2024, 12:19 AM

bz requested review of this revision.Nov 3 2024, 12:19 AM

Harbormaster completed remote builds in B60353: Diff 145913.Nov 3 2024, 12:19 AM

It's unfortunate there's so much duplication (already) here. Anyway I think this is OK. A comment might be useful although git blame on this file will turn up the reason this is here.

In D47408#1081453, @emaste wrote:

It's unfortunate there's so much duplication (already) here. Anyway I think this is OK. A comment might be useful although git blame on this file will turn up the reason this is here.

I was surprised by the duplication (see D47409 from April when I had a previous attempt to get the release and loader sorted). A battle for another day.
I think in this case it will be indeed the easiest to let the firmware port to do magic and remove this again. That way it won't be set for drivers which don't need it. Just not sure it can make it all in time. trying hard currently.

emaste accepted this revision as: emaste.Nov 3 2024, 5:48 PM

This revision is now accepted and ready to land.Nov 3 2024, 5:48 PM

trying hard currently.

Hey, I just want to say that myself and I hear a lot of people vocally amazed and cheering for you in our social spaces like discord. Everyone ITT is basically a superhero changing the entire world. Sorry for slightly OT/maybe spam.

bz added a child revision: D47406: release: add wifi-firmware-kmod@release to ship as package.Nov 3 2024, 11:47 PM

bz added a parent revision: D47407: release: install wireless firmware onto disc1 and dvd.

bz mentioned this in D47481: net/wifi-firmware-*: add support to set loader tunable.Nov 8 2024, 2:24 AM

I would give this up if D47481 can make it. Will help more cases than just this one as outlined there.

Abandon on favor of just committed D47481