Page MenuHomeFreeBSD

net/wifi-firmware-*: add support to set loader tunable
ClosedPublic

Authored by bz on Nov 8 2024, 2:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 11:45 AM
Unknown Object (File)
Fri, Dec 6, 1:16 PM
Unknown Object (File)
Mon, Dec 2, 12:40 PM
Unknown Object (File)
Sat, Nov 30, 1:16 PM
Unknown Object (File)
Wed, Nov 27, 11:06 AM
Unknown Object (File)
Nov 24 2024, 4:30 AM
Unknown Object (File)
Nov 24 2024, 4:28 AM
Unknown Object (File)
Nov 21 2024, 5:26 PM
Subscribers

Details

Summary

For drivers which currently need to set the
compat.linuxkpi.skb.mem_limit tunable add an option to the build
to create it automatically for each FLAVOR. There is no harm
if it is there multiple times setting it to the same value (apart
from file including and parsing overhead in loader -- however that
works).

Add the option to the rtw88 and rtw89 wifi-firmware Makefile.

Having it with the firmware package has multiple advantages:

  • the user does not have to do any manual configuration anymore
  • we do not have to configure setting it into the release builds
  • bsdinstall does not need to know about it to set for the installed system (depending on driver).

Sponsored by: The FreeBSD Foundation
MFC after: 1 hour
Superseeds: D47408

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Nov 8 2024, 2:24 AM
bz created this revision.

Increase PORTREVISION for the introduction of the loader TUNABLE files.

I had finished a 14.1 and current poudriere build before submitting also checking plists for both cases (given I had an error in one case in the first run I hope I got it right this time).

I'm not 100% certain that this is the right way to do "configuration" stuff from within ports, but I don't know enough about ports magic. Hopefully someone with more ports experience can chime in on this soon; if not, go ahead and commit since we need to get this into the tree soon for the release.

I'm not 100% certain that this is the right way to do "configuration" stuff from within ports, but I don't know enough about ports magic. Hopefully someone with more ports experience can chime in on this soon; if not, go ahead and commit since we need to get this into the tree soon for the release.

How "soon" is "soon"? Monday evening UTC or earlier?

In D47481#1083480, @bz wrote:

I'm not 100% certain that this is the right way to do "configuration" stuff from within ports, but I don't know enough about ports magic. Hopefully someone with more ports experience can chime in on this soon; if not, go ahead and commit since we need to get this into the tree soon for the release.

How "soon" is "soon"? Monday evening UTC or earlier?

Before you go to sleep tonight.

ACK and insta-MFC to the tagged Quaterly branch as well?

In D47481#1083490, @bz wrote:

ACK and insta-MFC to the tagged Quaterly branch as well?

Yes. If anyone raises issues on "post-commit review" they can MFC any fixes too. ;-)

This revision was not accepted when it landed; it landed in state Needs Review.Nov 10 2024, 11:23 PM
This revision was automatically updated to reflect the committed changes.